Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improving performances #42

Merged
merged 12 commits into from
Oct 11, 2023
Merged

improving performances #42

merged 12 commits into from
Oct 11, 2023

Conversation

jeertmans
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
differt2d/geometry.py 100.00% <100.00%> (+1.49%) ⬆️
differt2d/scene.py 100.00% <100.00%> (ø)
differt2d/utils.py 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Benchmark results:

Benchmark before changes
accumulate_on_transmitters_grid_over_paths_approx 53.7 ms 55.8 ms: 1.04x slower
path_method_image 49.9 us 53.7 us: 1.08x slower
path_method_MPT 760 us 772 us: 1.02x slower
Geometric mean (ref) 1.03x slower

Benchmark hidden because not significant (2): accumulate_on_transmitters_grid_over_paths_noapprox, path_method_FPT

@jeertmans jeertmans temporarily deployed to github-pages October 11, 2023 14:38 — with GitHub Actions Inactive
@jeertmans jeertmans temporarily deployed to github-pages October 11, 2023 14:47 — with GitHub Actions Inactive
@jeertmans jeertmans merged commit 4697002 into main Oct 11, 2023
@jeertmans jeertmans deleted the perf branch October 11, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeertmans