feat(lib): improve Sionna scenes support #98

jeertmans · 2024-06-28T14:51:38Z

No description provided.

codecov · 2024-06-28T14:56:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (9e92243) to head (0d4decd).
Report is 78 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   94.20%   97.54%   +3.33%     
==========================================
  Files          20       20              
  Lines         759      773      +14     
==========================================
+ Hits          715      754      +39     
+ Misses         44       19      -25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-06-28T14:57:51Z

Rust benchmark results:

group                                                       before                                 changes
-----                                                       ------                                 -------
complete_graph_all_paths/iter                               1.00     23.1±0.41ns 41.2 MElem/sec    1.00     23.1±0.60ns 41.3 MElem/sec
complete_graph_all_paths_array_chunks/1                     1.00     32.8±0.61ns 29.0 MElem/sec    1.01     33.2±1.11ns 28.7 MElem/sec
complete_graph_all_paths_array_chunks/10                    1.00    356.0±4.01ns 26.8 MElem/sec    1.06   378.2±12.74ns 25.2 MElem/sec
complete_graph_all_paths_array_chunks/100                   1.03      2.6±0.18µs 36.7 MElem/sec    1.00      2.5±0.08µs 37.7 MElem/sec
complete_graph_all_paths_array_chunks/1000                  1.00     22.8±0.44µs 41.8 MElem/sec    1.01     23.0±0.88µs 41.5 MElem/sec
di_graph_from_complete_graph_all_paths/iter                 1.00    224.7±5.54ns  4.2 MElem/sec    1.01    227.0±3.34ns  4.2 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1       1.00    236.6±5.70ns  4.0 MElem/sec    1.00    237.2±7.47ns  4.0 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/10      1.02      2.6±0.05µs  3.7 MElem/sec    1.00      2.5±0.03µs  3.8 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/100     1.01     23.2±0.56µs  4.1 MElem/sec    1.00     22.9±0.33µs  4.2 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1000    1.00   223.0±11.89µs  4.3 MElem/sec    1.15   256.5±12.22µs  3.7 MElem/sec

github-actions · 2024-06-28T14:57:59Z

Python benchmark results:


-------------------------------- benchmark 'complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                    Mean              StdDev            OPS (Mops/s)          
---------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths (0006_pgo)         627.4802 (1.0)      506.8919 (1.93)           1.5937 (1.0)    
test_complete_graph_all_paths (0002_changes)     725.3214 (1.16)     262.5240 (1.0)            1.3787 (0.87)   
test_complete_graph_all_paths (0010_before)      665.4972 (1.06)     761.2174 (2.90)           1.5026 (0.94)   
---------------------------------------------------------------------------------------------------------------

----------------------------------- benchmark 'complete_graph_all_paths_array_chunks': 12 tests ------------------------------------
Name (time in ns)                                                       Mean                StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1000] (0005_pgo)          47.7108 (1.0)         26.3354 (4.99)          20.9596 (1.0)    
test_complete_graph_all_paths_array_chunks[1000] (0009_before)       54.5246 (1.14)         5.2773 (1.0)           18.3403 (0.88)   
test_complete_graph_all_paths_array_chunks[100] (0008_pgo)           65.5466 (1.37)       289.4110 (54.84)         15.2563 (0.73)   
test_complete_graph_all_paths_array_chunks[100] (0004_changes)       74.3773 (1.56)        62.8735 (11.91)         13.4450 (0.64)   
test_complete_graph_all_paths_array_chunks[1000] (0001_changes)      55.0668 (1.15)       107.9539 (20.46)         18.1598 (0.87)   
test_complete_graph_all_paths_array_chunks[100] (0012_before)        74.3850 (1.56)        66.8236 (12.66)         13.4436 (0.64)   
test_complete_graph_all_paths_array_chunks[10] (0008_pgo)           130.4294 (2.73)        30.2847 (5.74)           7.6670 (0.37)   
test_complete_graph_all_paths_array_chunks[10] (0004_changes)       151.2481 (3.17)       197.9550 (37.51)          6.6117 (0.32)   
test_complete_graph_all_paths_array_chunks[10] (0012_before)        166.8641 (3.50)        39.3728 (7.46)           5.9929 (0.29)   
test_complete_graph_all_paths_array_chunks[1] (0010_before)         663.6624 (13.91)    1,442.9431 (273.42)         1.5068 (0.07)   
test_complete_graph_all_paths_array_chunks[1] (0006_pgo)            561.3346 (11.77)    1,304.9316 (247.27)         1.7815 (0.08)   
test_complete_graph_all_paths_array_chunks[1] (0002_changes)        699.4072 (14.66)    3,134.5402 (593.96)         1.4298 (0.07)   
------------------------------------------------------------------------------------------------------------------------------------

--------------------------------------- benchmark 'di_graph_complete_graph_all_paths_array_chunks': 12 tests ---------------------------------------
Name (time in ns)                                                                       Mean                StdDev            OPS (Kops/s)          
----------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0008_pgo)            251.5152 (1.0)         30.8326 (1.08)       3,975.9028 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0007_pgo)           264.7210 (1.05)        67.9207 (2.39)       3,777.5622 (0.95)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0012_before)         267.6137 (1.06)        30.4692 (1.07)       3,736.7289 (0.94)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0004_changes)        290.9279 (1.16)        60.0055 (2.11)       3,437.2777 (0.86)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0011_before)        259.6438 (1.03)        28.4312 (1.0)        3,851.4304 (0.97)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0003_changes)       289.2255 (1.15)        55.9207 (1.97)       3,457.5102 (0.87)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0007_pgo)             508.1758 (2.02)     1,870.3151 (65.78)      1,967.8228 (0.49)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0003_changes)         516.6882 (2.05)       794.8205 (27.96)      1,935.4032 (0.49)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0011_before)          513.6898 (2.04)       565.4723 (19.89)      1,946.7000 (0.49)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0007_pgo)            1,075.0708 (4.27)     1,827.8731 (64.29)        930.1713 (0.23)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0011_before)         1,171.8769 (4.66)     1,066.6766 (37.52)        853.3320 (0.21)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0003_changes)        1,191.4251 (4.74)     3,615.5842 (127.17)       839.3310 (0.21)   
----------------------------------------------------------------------------------------------------------------------------------------------------

---------------------------------- benchmark 'di_graph_from_complete_graph_all_paths': 3 tests ----------------------------------
Name (time in ns)                                                    Mean                StdDev            OPS (Kops/s)          
---------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths (0001_changes)     1,284.2778 (1.23)     8,436.4308 (12.60)        778.6477 (0.81)   
test_di_graph_from_complete_graph_all_paths (0009_before)      1,237.7229 (1.19)       669.3684 (1.0)          807.9353 (0.84)   
test_di_graph_from_complete_graph_all_paths (0005_pgo)         1,041.5424 (1.0)      1,135.4739 (1.70)         960.1145 (1.0)    
---------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

github-actions · 2024-07-24T20:08:51Z

docs/source/notebooks/quickstart.ipynb

@@ -65,10 +66,10 @@
   "metadata": {},
   "outputs": [],
   "source": [
-    "file = get_sionna_scene(\"box\")\n",
+    "file = get_sionna_scene(\"etoile\")\n",


[LanguageTool] _{reported by reviewdog 🐶}
Unpaired symbol: ‘"’ seems to be missing (EN_UNPAIRED_QUOTES)
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-parentheses
Rule: https://community.languagetool.org/rule/show/EN_UNPAIRED_QUOTES?lang=en-US
Category: PUNCTUATION

jeertmans added 2 commits June 28, 2024 16:50

feat(lib): improve Sionna scenes support

7961322

chore(lib): add missing type hint

d254d9e

jeertmans temporarily deployed to release June 28, 2024 14:51 — with GitHub Actions Inactive

github-actions bot added python Changes Python code rust Changes Rust code tests Changes tests benchmarks Changes benchmarks labels Jun 28, 2024

fix(tests): match regex for Windows

e4de5b3

jeertmans temporarily deployed to release June 28, 2024 15:21 — with GitHub Actions Inactive

fix(tests): regex

7375ce1

jeertmans temporarily deployed to release June 28, 2024 15:59 — with GitHub Actions Inactive

jeertmans added 2 commits July 24, 2024 14:42

chore(tests): add type hint

9ec402f

chore(docs): fix type hints?

92e2a07

jeertmans temporarily deployed to release July 24, 2024 13:27 — with GitHub Actions Inactive

test: does this work?

77c1bb6

jeertmans temporarily deployed to release July 24, 2024 13:36 — with GitHub Actions Inactive

chore(lib): fixing type hint issues and nested bsdf

3d8f383

github-actions bot added the ci Continuous integration (tests, lints, ...) label Jul 24, 2024

Merge branch 'main' into sionna-scenes

b76f6e1

jeertmans temporarily deployed to release July 24, 2024 19:22 — with GitHub Actions Inactive

fix(lib): typo

fedb1b9

jeertmans temporarily deployed to release July 24, 2024 19:39 — with GitHub Actions Inactive

fix(lib): typos

19d09db

jeertmans temporarily deployed to release July 24, 2024 19:42 — with GitHub Actions Inactive

fix(tests): remove nonsense test

f1d9c06

jeertmans temporarily deployed to release July 24, 2024 19:46 — with GitHub Actions Inactive

fix(docs): cleanings

11ba688

jeertmans temporarily deployed to release July 24, 2024 20:08 — with GitHub Actions Inactive

github-actions bot added the documentation Improvements or additions to documentation label Jul 24, 2024

github-actions bot reviewed Jul 24, 2024

View reviewed changes

fix(docs): typo in type hint

1eba75a

jeertmans temporarily deployed to release July 24, 2024 20:21 — with GitHub Actions Inactive

fix(docs): typo

ab54ad7

jeertmans temporarily deployed to release July 24, 2024 20:36 — with GitHub Actions Inactive

chore(lib): fmt and tests

0d4decd

jeertmans temporarily deployed to release July 25, 2024 08:15 — with GitHub Actions Inactive

jeertmans merged commit 0cf7195 into main Jul 25, 2024
49 checks passed

jeertmans deleted the sionna-scenes branch July 25, 2024 08:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lib): improve Sionna scenes support #98

feat(lib): improve Sionna scenes support #98

jeertmans commented Jun 28, 2024

codecov bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot Jul 24, 2024

feat(lib): improve Sionna scenes support #98

feat(lib): improve Sionna scenes support #98

Conversation

jeertmans commented Jun 28, 2024

codecov bot commented Jun 28, 2024 • edited Loading

Codecov Report

github-actions bot commented Jun 28, 2024 • edited Loading

github-actions bot commented Jun 28, 2024 • edited Loading

github-actions bot Jul 24, 2024

Choose a reason for hiding this comment

codecov bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading