Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): add random sampling and ML features #85

Merged
merged 17 commits into from
Jun 11, 2024
Merged

feat(lib): add random sampling and ML features #85

merged 17 commits into from
Jun 11, 2024

Conversation

jeertmans
Copy link
Owner

No description provided.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 95.08197% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.57%. Comparing base (14f6f4b) to head (94ed298).

Current head 94ed298 differs from pull request most recent head 513a01b

Please upload reports for the commit 513a01b to get more accurate results.

Files Patch % Lines
differt/src/differt/geometry/triangle_mesh.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          35       35           
  Lines        1252     1284   +32     
=======================================
+ Hits         1134     1163   +29     
- Misses        118      121    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 6, 2024

Rust benchmark results:

group                                                       before                                 changes
-----                                                       ------                                 -------
complete_graph_all_paths/iter                               1.04     23.6±0.14ns 40.5 MElem/sec    1.00     22.7±0.33ns 42.0 MElem/sec
complete_graph_all_paths_array_chunks/1                     1.00     32.9±0.21ns 29.0 MElem/sec    1.00     32.8±1.46ns 29.1 MElem/sec
complete_graph_all_paths_array_chunks/10                    1.00    354.3±6.15ns 26.9 MElem/sec    1.02   360.4±18.80ns 26.5 MElem/sec
complete_graph_all_paths_array_chunks/100                   1.00      2.5±0.04µs 37.8 MElem/sec    1.02      2.6±0.04µs 36.9 MElem/sec
complete_graph_all_paths_array_chunks/1000                  1.00     22.7±0.22µs 42.1 MElem/sec    1.01     22.9±0.51µs 41.7 MElem/sec
di_graph_from_complete_graph_all_paths/iter                 1.00    218.7±3.96ns  4.4 MElem/sec    1.00    219.7±4.45ns  4.3 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1       1.06    243.3±3.86ns  3.9 MElem/sec    1.00    230.0±3.20ns  4.1 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/10      1.05      2.7±0.02µs  3.6 MElem/sec    1.00      2.5±0.07µs  3.8 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/100     1.00     23.0±0.11µs  4.2 MElem/sec    1.06     24.4±0.41µs  3.9 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1000    1.00    220.7±4.35µs  4.3 MElem/sec    1.07    235.2±3.80µs  4.1 MElem/sec

Copy link
Contributor

github-actions bot commented May 6, 2024

Python benchmark results:


-------------------------------- benchmark 'complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                    Mean              StdDev            OPS (Mops/s)          
---------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths (0003_before)      363.4728 (1.11)      98.0898 (1.0)            2.7512 (0.90)   
test_complete_graph_all_paths (0001_changes)     383.1352 (1.17)     130.9478 (1.33)           2.6100 (0.85)   
test_complete_graph_all_paths (0002_pgo)         327.2644 (1.0)      305.9501 (3.12)           3.0556 (1.0)    
---------------------------------------------------------------------------------------------------------------

----------------------------------- benchmark 'complete_graph_all_paths_array_chunks': 12 tests ------------------------------------
Name (time in ns)                                                       Mean                StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1000] (0002_pgo)          31.2190 (1.0)        188.3246 (4.15)          32.0318 (1.0)    
test_complete_graph_all_paths_array_chunks[1000] (0003_before)       31.5264 (1.01)       177.6103 (3.91)          31.7195 (0.99)   
test_complete_graph_all_paths_array_chunks[1000] (0001_changes)      32.3253 (1.04)       182.3472 (4.01)          30.9355 (0.97)   
test_complete_graph_all_paths_array_chunks[100] (0002_pgo)           35.9567 (1.15)        96.9454 (2.13)          27.8112 (0.87)   
test_complete_graph_all_paths_array_chunks[100] (0003_before)        40.1610 (1.29)       191.5767 (4.22)          24.8998 (0.78)   
test_complete_graph_all_paths_array_chunks[100] (0001_changes)       40.6909 (1.30)       239.5330 (5.27)          24.5755 (0.77)   
test_complete_graph_all_paths_array_chunks[10] (0002_pgo)            69.7094 (2.23)       283.8184 (6.25)          14.3453 (0.45)   
test_complete_graph_all_paths_array_chunks[10] (0001_changes)        75.3397 (2.41)       196.5436 (4.33)          13.2732 (0.41)   
test_complete_graph_all_paths_array_chunks[10] (0003_before)         74.9060 (2.40)        45.4200 (1.0)           13.3501 (0.42)   
test_complete_graph_all_paths_array_chunks[1] (0002_pgo)            346.7007 (11.11)    1,007.8784 (22.19)          2.8843 (0.09)   
test_complete_graph_all_paths_array_chunks[1] (0003_before)         331.8411 (10.63)    1,758.4626 (38.72)          3.0135 (0.09)   
test_complete_graph_all_paths_array_chunks[1] (0001_changes)        329.3748 (10.55)      761.9495 (16.78)          3.0361 (0.09)   
------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------- benchmark 'di_graph_complete_graph_all_paths_array_chunks': 12 tests --------------------------------------
Name (time in ns)                                                                     Mean                StdDev            OPS (Mops/s)          
--------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0002_pgo)         230.9452 (1.0)         23.6667 (3.17)           4.3300 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0002_pgo)          265.9033 (1.15)        37.7103 (5.05)           3.7608 (0.87)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0003_before)      241.2931 (1.04)         7.4732 (1.0)            4.1443 (0.96)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0003_before)       265.5345 (1.15)        32.4120 (4.34)           3.7660 (0.87)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0001_changes)     243.0455 (1.05)        21.9131 (2.93)           4.1145 (0.95)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0001_changes)      262.8645 (1.14)        22.8865 (3.06)           3.8042 (0.88)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0002_pgo)           326.4611 (1.41)        90.9114 (12.17)          3.0632 (0.71)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0001_changes)       330.3072 (1.43)       167.4963 (22.41)          3.0275 (0.70)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0003_before)        328.1503 (1.42)       138.0705 (18.48)          3.0474 (0.70)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0002_pgo)            584.6661 (2.53)       955.7408 (127.89)         1.7104 (0.40)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0003_before)         617.6416 (2.67)     1,187.1473 (158.85)         1.6191 (0.37)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0001_changes)        636.8994 (2.76)       442.2497 (59.18)          1.5701 (0.36)   
--------------------------------------------------------------------------------------------------------------------------------------------------

--------------------------------- benchmark 'di_graph_from_complete_graph_all_paths': 3 tests ---------------------------------
Name (time in ns)                                                  Mean                StdDev            OPS (Mops/s)          
-------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths (0002_pgo)         582.2733 (1.0)        734.6960 (1.37)           1.7174 (1.0)    
test_di_graph_from_complete_graph_all_paths (0001_changes)     586.8701 (1.01)       534.4194 (1.0)            1.7040 (0.99)   
test_di_graph_from_complete_graph_all_paths (0003_before)      597.3748 (1.03)     1,120.0231 (2.10)           1.6740 (0.97)   
-------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@jeertmans jeertmans merged commit 2a4e99c into main Jun 11, 2024
41 of 46 checks passed
@jeertmans jeertmans deleted the deep-sets branch June 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant