Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): enhance ML-sampling model #220

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

jeertmans
Copy link
Owner

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.36%. Comparing base (90bdb1d) to head (6dc46e1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   84.36%   84.36%           
=======================================
  Files          30       30           
  Lines        2405     2405           
=======================================
  Hits         2029     2029           
  Misses        376      376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #220 will degrade performances by 17.16%

Comparing better-sampling (6dc46e1) with main (5a9c99c)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compile_compute_paths 1.7 s 2.1 s -17.16%

"from tqdm.notebook import tqdm, trange\n",
"from beartype import beartype as typechecker\n",
"from jaxtyping import Array, Float, Int, PRNGKeyArray, jaxtyped\n",
"from tqdm.notebook import trange\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Notebook, notebook
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant