-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lib): make plotting utilities accept JAX arrays #146
Conversation
"# differt.plotting (dplt) works with NumPy arrays, not JAX arrays\n", | ||
"vertices = np.asarray(mesh.vertices)\n", | ||
"triangles = np.asarray(mesh.triangles[select, :])\n", | ||
"vertices = mesh.vertices\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Vertices
, vertices
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
"vertices = np.asarray(mesh.vertices)\n", | ||
"triangles = np.asarray(mesh.triangles[select, :])\n", | ||
"vertices = mesh.vertices\n", | ||
"triangles = mesh.triangles[select, :]\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Triangles
, triangles
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 79.34% 80.10% +0.76%
==========================================
Files 25 25
Lines 1753 1820 +67
==========================================
+ Hits 1391 1458 +67
Misses 362 362 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #146 will not alter performanceComparing Summary
|
No description provided.