Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib): make plotting utilities accept JAX arrays #146

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

jeertmans
Copy link
Owner

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation visualization Related to visualization utilities python Changes Python code tests Changes tests labels Oct 14, 2024
"# differt.plotting (dplt) works with NumPy arrays, not JAX arrays\n",
"vertices = np.asarray(mesh.vertices)\n",
"triangles = np.asarray(mesh.triangles[select, :])\n",
"vertices = mesh.vertices\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Vertices, vertices
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING

"vertices = np.asarray(mesh.vertices)\n",
"triangles = np.asarray(mesh.triangles[select, :])\n",
"vertices = mesh.vertices\n",
"triangles = mesh.triangles[select, :]\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Triangles, triangles
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (ef9013e) to head (b9daffb).
Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   79.34%   80.10%   +0.76%     
==========================================
  Files          25       25              
  Lines        1753     1820      +67     
==========================================
+ Hits         1391     1458      +67     
  Misses        362      362              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #146 will not alter performance

Comparing avoid-asarray (b9daffb) with main (ef9013e)

Summary

✅ 15 untouched benchmarks

@jeertmans jeertmans merged commit 451ad49 into main Oct 14, 2024
46 checks passed
@jeertmans jeertmans deleted the avoid-asarray branch October 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Changes Python code tests Changes tests visualization Related to visualization utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant