Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib): calibrate path tracing #127

Merged
merged 8 commits into from
Oct 5, 2024
Merged

chore(lib): calibrate path tracing #127

merged 8 commits into from
Oct 5, 2024

Conversation

jeertmans
Copy link
Owner

Calibrate path tracing utility such that it avoids invalid paths.

Calibrate path tracing utility such that it avoids invalid paths.
@github-actions github-actions bot added the python Changes Python code label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.43%. Comparing base (1ff3d26) to head (b8c928c).
Report is 107 commits behind head on main.

Files with missing lines Patch % Lines
differt-core/src/geometry/triangle_mesh.rs 0.00% 7 Missing ⚠️
differt/src/differt/rt/utils.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   78.44%   78.43%   -0.02%     
==========================================
  Files          25       25              
  Lines        1670     1683      +13     
==========================================
+ Hits         1310     1320      +10     
- Misses        360      363       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 2, 2024

CodSpeed Performance Report

Merging #127 will improve performances by 16.63%

Comparing calibration (b8c928c) with main (1ff3d26)

Summary

⚡ 2 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark main calibration Change
test_compute_paths_in_simple_street_canyon_scene[20000-1] 2.1 s 1.8 s +16.63%
test_compute_paths_in_simple_street_canyon_scene[None-1] 2.2 s 2 s +15.14%

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 3, 2024
@jeertmans jeertmans merged commit aacc362 into main Oct 5, 2024
46 of 48 checks passed
@jeertmans jeertmans deleted the calibration branch October 5, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Changes Python code rust Changes Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant