Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lib): unroll image method and use_scan=True/False #119

Merged
merged 10 commits into from
Sep 28, 2024
Merged

perf(lib): unroll image method and use_scan=True/False #119

merged 10 commits into from
Sep 28, 2024

Conversation

jeertmans
Copy link
Owner

No description provided.

@github-actions github-actions bot added python Changes Python code rust Changes Rust code labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.82%. Comparing base (e23f941) to head (5bdcc0a).
Report is 119 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   77.74%   77.82%   +0.08%     
==========================================
  Files          25       25              
  Lines        1532     1538       +6     
==========================================
+ Hits         1191     1197       +6     
  Misses        341      341              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans removed the rust Changes Rust code label Sep 27, 2024
Copy link

codspeed-hq bot commented Sep 27, 2024

CodSpeed Performance Report

Merging #119 will degrade performances by 98.39%

Comparing perf (73a4fde) with main (e23f941)

Summary

⚡ 1 improvements
❌ 9 regressions
✅ 5 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main perf Change
test_compute_paths_in_simple_street_canyon_scene[20000-0] 1,497.3 ms 36.1 ms ×41
test_compute_paths_in_simple_street_canyon_scene[20000-1] 38.3 ms 2,372.7 ms -98.39%
test_compute_paths_in_simple_street_canyon_scene[20000-2] 2 s 2.3 s -13.36%
test_compute_paths_in_simple_street_canyon_scene[None-1] 2.2 s 2.5 s -12.36%
test_compute_paths_in_simple_street_canyon_scene[None-2] 2.6 s 2.9 s -10.52%
test_image_method[batch0] 329.2 ms 472.2 ms -30.29%
test_image_method[batch1] 383.3 ms 573 ms -33.11%
test_image_method[batch2] 453 ms 711.7 ms -36.35%
test_transmitter_visibility_in_simple_street_canyon_scene[10000] 813.5 ms 925 ms -12.05%
test_transmitter_visibility_in_simple_street_canyon_scene[1000] 498.3 ms 595.2 ms -16.29%

@github-actions github-actions bot added tests Changes tests benchmarks Changes benchmarks labels Sep 27, 2024
@jeertmans jeertmans changed the title perf(lib): unroll image method and use_scan=False perf(lib): unroll image method and use_scan=True/False Sep 28, 2024
@jeertmans jeertmans merged commit 2a03c81 into main Sep 28, 2024
37 of 40 checks passed
@jeertmans jeertmans deleted the perf branch September 28, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Changes benchmarks python Changes Python code tests Changes tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant