chore(lib): warn about overflow and add Rust coverage #116

jeertmans · 2024-09-18T11:04:17Z

No description provided.

github-actions · 2024-09-18T11:09:07Z

Python benchmark results:


------------------------------- benchmark 'test_complete_graph_all_paths': 3 tests ------------------------------
Name (time in ns)                                    Mean                StdDev            OPS (Mops/s)          
-----------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths (0006_pgo)         636.9522 (1.0)      2,051.0278 (6.53)           1.5700 (1.0)    
test_complete_graph_all_paths (0010_before)      669.8244 (1.05)       314.2121 (1.0)            1.4929 (0.95)   
test_complete_graph_all_paths (0002_changes)     781.2865 (1.23)     3,554.4915 (11.31)          1.2799 (0.82)   
-----------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_complete_graph_all_paths_array_chunks[1000]': 3 tests -----------------------------
Name (time in ns)                                                      Mean              StdDev            OPS (Mops/s)          
---------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1000] (0005_pgo)         54.2242 (1.0)      180.3651 (2.66)          18.4420 (1.0)    
test_complete_graph_all_paths_array_chunks[1000] (0009_before)      57.7727 (1.07)     157.6794 (2.33)          17.3092 (0.94)   
test_complete_graph_all_paths_array_chunks[1000] (0001_changes)     56.6259 (1.04)      67.7085 (1.0)           17.6598 (0.96)   
---------------------------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_complete_graph_all_paths_array_chunks[100]': 3 tests -----------------------------
Name (time in ns)                                                     Mean              StdDev            OPS (Mops/s)          
--------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[100] (0004_changes)     74.6635 (1.10)     521.7640 (3.53)          13.3934 (0.91)   
test_complete_graph_all_paths_array_chunks[100] (0007_pgo)         68.0634 (1.0)      147.8016 (1.0)           14.6922 (1.0)    
test_complete_graph_all_paths_array_chunks[100] (0012_before)      76.1510 (1.12)     563.4842 (3.81)          13.1318 (0.89)   
--------------------------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_complete_graph_all_paths_array_chunks[10]': 3 tests ------------------------------
Name (time in ns)                                                     Mean              StdDev            OPS (Mops/s)          
--------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[10] (0007_pgo)         141.3856 (1.0)      282.4776 (2.62)           7.0729 (1.0)    
test_complete_graph_all_paths_array_chunks[10] (0004_changes)     153.6111 (1.09)     225.5184 (2.09)           6.5099 (0.92)   
test_complete_graph_all_paths_array_chunks[10] (0012_before)      164.0624 (1.16)     107.7840 (1.0)            6.0952 (0.86)   
--------------------------------------------------------------------------------------------------------------------------------

------------------------------- benchmark 'test_complete_graph_all_paths_array_chunks[1]': 3 tests ------------------------------
Name (time in ns)                                                    Mean                StdDev            OPS (Mops/s)          
---------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1] (0006_pgo)         577.2670 (1.0)      1,813.9980 (1.43)           1.7323 (1.0)    
test_complete_graph_all_paths_array_chunks[1] (0010_before)      647.3915 (1.12)     1,267.7887 (1.0)            1.5447 (0.89)   
test_complete_graph_all_paths_array_chunks[1] (0002_changes)     637.5354 (1.10)     1,901.8132 (1.50)           1.5685 (0.91)   
---------------------------------------------------------------------------------------------------------------------------------

-------------------------------- benchmark 'test_di_graph_from_complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                                    Mean                 StdDev            OPS (Kops/s)          
----------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths (0001_changes)     1,375.3867 (1.07)      6,156.7592 (1.0)          727.0683 (0.94)   
test_di_graph_from_complete_graph_all_paths (0005_pgo)         1,289.8218 (1.0)       6,305.2828 (1.02)         775.3009 (1.0)    
test_di_graph_from_complete_graph_all_paths (0009_before)      1,445.2814 (1.12)     10,026.5593 (1.63)         691.9068 (0.89)   
----------------------------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_di_graph_from_complete_graph_all_paths_array_chunks[1000]': 3 tests -----------------------------
Name (time in ns)                                                                     Mean             StdDev            OPS (Mops/s)          
-----------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0008_pgo)         256.6352 (1.0)      15.7619 (1.0)            3.8966 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0012_before)      264.0209 (1.03)     41.0266 (2.60)           3.7876 (0.97)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0003_changes)     264.2767 (1.03)     51.2146 (3.25)           3.7839 (0.97)   
-----------------------------------------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_di_graph_from_complete_graph_all_paths_array_chunks[100]': 3 tests -----------------------------
Name (time in ns)                                                                    Mean             StdDev            OPS (Mops/s)          
----------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0011_before)      299.9274 (1.09)     35.4056 (1.0)            3.3341 (0.92)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0007_pgo)         276.0610 (1.0)      35.4957 (1.00)           3.6224 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0004_changes)     283.0656 (1.03)     61.0959 (1.73)           3.5327 (0.98)   
----------------------------------------------------------------------------------------------------------------------------------------------

------------------------------ benchmark 'test_di_graph_from_complete_graph_all_paths_array_chunks[10]': 3 tests -------------------------------
Name (time in ns)                                                                   Mean                StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0008_pgo)         518.8111 (1.0)        449.2752 (1.0)            1.9275 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0011_before)      593.6856 (1.14)     1,911.7989 (4.26)           1.6844 (0.87)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0003_changes)     557.9116 (1.08)     1,611.2520 (3.59)           1.7924 (0.93)   
------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------- benchmark 'test_di_graph_from_complete_graph_all_paths_array_chunks[1]': 3 tests -------------------------------
Name (time in ns)                                                                    Mean                StdDev            OPS (Kops/s)          
-------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0008_pgo)         1,097.4256 (1.0)        850.1574 (1.39)         911.2235 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0003_changes)     1,331.9952 (1.21)     7,103.2681 (11.58)        750.7534 (0.82)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0011_before)      1,316.1165 (1.20)       613.2237 (1.0)          759.8111 (0.83)   
-------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

github-actions · 2024-09-18T11:11:13Z

Rust benchmark results:

group                                                       before                                 changes
-----                                                       ------                                 -------
complete_graph_all_paths/iter                               1.00     24.0±0.12ns 39.7 MElem/sec    1.02     24.4±0.34ns 39.1 MElem/sec
complete_graph_all_paths_array_chunks/1                     1.00     32.5±0.45ns 29.3 MElem/sec    1.00     32.7±0.48ns 29.2 MElem/sec
complete_graph_all_paths_array_chunks/10                    1.04    362.5±4.44ns 26.3 MElem/sec    1.00    349.7±2.91ns 27.3 MElem/sec
complete_graph_all_paths_array_chunks/100                   1.00      2.4±0.02µs 39.6 MElem/sec    1.06      2.6±0.04µs 37.3 MElem/sec
complete_graph_all_paths_array_chunks/1000                  1.00     22.2±0.16µs 43.0 MElem/sec    1.00     22.2±0.35µs 42.9 MElem/sec
di_graph_from_complete_graph_all_paths/iter                 1.00    229.6±7.74ns  4.2 MElem/sec    1.03    236.0±3.47ns  4.0 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1       1.01    241.2±1.82ns  4.0 MElem/sec    1.00    239.9±1.92ns  4.0 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/10      1.02      2.7±0.04µs  3.6 MElem/sec    1.00      2.6±0.04µs  3.7 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/100     1.10     25.9±0.39µs  3.7 MElem/sec    1.00     23.5±0.34µs  4.1 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1000    1.11    250.1±3.08µs  3.8 MElem/sec    1.00    226.1±1.61µs  4.2 MElem/sec

codecov · 2024-09-18T12:18:14Z

Codecov Report

Attention: Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.79%. Comparing base (0ad8c07) to head (d1673bf).
Report is 120 commits behind head on main.

Files with missing lines	Patch %	Lines
differt-core/src/rt/graph.rs	54.16%	11 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #116       +/-   ##
===========================================
- Coverage   98.93%   74.79%   -24.15%     
===========================================
  Files          20       28        +8     
  Lines         847     1349      +502     
===========================================
+ Hits          838     1009      +171     
- Misses          9      340      +331

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chore(lib): warn about overflow and add Rust coverage

6ebfa2b

jeertmans temporarily deployed to release September 18, 2024 11:04 — with GitHub Actions Inactive

github-actions bot added ci Continuous integration (tests, lints, ...) python Changes Python code rust Changes Rust code tests Changes tests labels Sep 18, 2024

fix(ci): setup Python inside container

78a1afa

jeertmans temporarily deployed to release September 18, 2024 11:14 — with GitHub Actions Inactive

jeertmans temporarily deployed to release September 18, 2024 11:16 — with GitHub Actions Inactive

jeertmans temporarily deployed to release September 18, 2024 11:21 — with GitHub Actions Inactive

jeertmans temporarily deployed to release September 18, 2024 11:33 — with GitHub Actions Inactive

jeertmans temporarily deployed to release September 18, 2024 11:48 — with GitHub Actions Inactive

chore(ci): does it work?

7bb7da1

jeertmans force-pushed the overflow branch from a91cd2b to 7bb7da1 Compare September 18, 2024 12:15

jeertmans temporarily deployed to release September 18, 2024 12:15 — with GitHub Actions Inactive

chore(ci): setup-python reads .python-version

3096522

jeertmans temporarily deployed to release September 18, 2024 12:18 — with GitHub Actions Inactive

fix(ci): .python-version

df34f56

jeertmans temporarily deployed to release September 18, 2024 12:19 — with GitHub Actions Inactive

fix(ci): install cargo-tarpaulin manually

d1673bf

jeertmans temporarily deployed to release September 18, 2024 12:29 — with GitHub Actions Inactive

jeertmans merged commit 975205b into main Sep 18, 2024
46 of 49 checks passed

jeertmans deleted the overflow branch September 18, 2024 12:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(lib): warn about overflow and add Rust coverage #116

chore(lib): warn about overflow and add Rust coverage #116

jeertmans commented Sep 18, 2024

github-actions bot commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading

codecov bot commented Sep 18, 2024 •

edited

Loading

chore(lib): warn about overflow and add Rust coverage #116

chore(lib): warn about overflow and add Rust coverage #116

Conversation

jeertmans commented Sep 18, 2024

github-actions bot commented Sep 18, 2024 • edited Loading

github-actions bot commented Sep 18, 2024 • edited Loading

codecov bot commented Sep 18, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading

codecov bot commented Sep 18, 2024 •

edited

Loading