feat(lib): enhance core library #115

jeertmans · 2024-09-17T14:17:47Z

No description provided.

github-actions · 2024-09-17T14:23:31Z

Python benchmark results:


------------------------------- benchmark 'test_complete_graph_all_paths': 3 tests ------------------------------
Name (time in ns)                                    Mean                StdDev            OPS (Mops/s)          
-----------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths (0010_before)      694.9955 (1.19)     1,581.1321 (3.00)           1.4389 (0.84)   
test_complete_graph_all_paths (0006_pgo)         582.5059 (1.0)        526.2360 (1.0)            1.7167 (1.0)    
test_complete_graph_all_paths (0002_changes)     724.3999 (1.24)     1,578.1385 (3.00)           1.3805 (0.80)   
-----------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_complete_graph_all_paths_array_chunks[1000]': 3 tests -----------------------------
Name (time in ns)                                                      Mean              StdDev            OPS (Mops/s)          
---------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1000] (0001_changes)     58.5463 (1.21)     200.2469 (13.45)         17.0805 (0.83)   
test_complete_graph_all_paths_array_chunks[1000] (0005_pgo)         48.3744 (1.0)       14.8905 (1.0)           20.6721 (1.0)    
test_complete_graph_all_paths_array_chunks[1000] (0009_before)      56.7983 (1.17)     136.3668 (9.16)          17.6062 (0.85)   
---------------------------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_complete_graph_all_paths_array_chunks[100]': 3 tests -----------------------------
Name (time in ns)                                                     Mean              StdDev            OPS (Mops/s)          
--------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[100] (0004_changes)     77.4812 (1.14)     643.1383 (1.79)          12.9064 (0.88)   
test_complete_graph_all_paths_array_chunks[100] (0007_pgo)         68.2127 (1.0)      446.2404 (1.24)          14.6600 (1.0)    
test_complete_graph_all_paths_array_chunks[100] (0012_before)      74.8170 (1.10)     359.2946 (1.0)           13.3660 (0.91)   
--------------------------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_complete_graph_all_paths_array_chunks[10]': 3 tests ------------------------------
Name (time in ns)                                                     Mean              StdDev            OPS (Mops/s)          
--------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[10] (0007_pgo)         144.0461 (1.0)      213.9367 (1.12)           6.9422 (1.0)    
test_complete_graph_all_paths_array_chunks[10] (0004_changes)     151.8914 (1.05)     191.6016 (1.0)            6.5836 (0.95)   
test_complete_graph_all_paths_array_chunks[10] (0012_before)      162.7965 (1.13)     306.7274 (1.60)           6.1426 (0.88)   
--------------------------------------------------------------------------------------------------------------------------------

------------------------------- benchmark 'test_complete_graph_all_paths_array_chunks[1]': 3 tests ------------------------------
Name (time in ns)                                                    Mean                StdDev            OPS (Mops/s)          
---------------------------------------------------------------------------------------------------------------------------------
test_complete_graph_all_paths_array_chunks[1] (0006_pgo)         554.2320 (1.0)      1,274.1964 (1.0)            1.8043 (1.0)    
test_complete_graph_all_paths_array_chunks[1] (0002_changes)     672.1774 (1.21)     1,317.0628 (1.03)           1.4877 (0.82)   
test_complete_graph_all_paths_array_chunks[1] (0010_before)      628.5775 (1.13)     1,826.1890 (1.43)           1.5909 (0.88)   
---------------------------------------------------------------------------------------------------------------------------------

-------------------------------- benchmark 'test_di_graph_from_complete_graph_all_paths': 3 tests --------------------------------
Name (time in ns)                                                    Mean                 StdDev            OPS (Kops/s)          
----------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths (0005_pgo)         1,220.2599 (1.0)       7,269.0294 (1.0)          819.4976 (1.0)    
test_di_graph_from_complete_graph_all_paths (0009_before)      1,432.4413 (1.17)     10,047.2545 (1.38)         698.1089 (0.85)   
test_di_graph_from_complete_graph_all_paths (0001_changes)     1,388.5755 (1.14)      8,484.5667 (1.17)         720.1625 (0.88)   
----------------------------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_di_graph_from_complete_graph_all_paths_array_chunks[1000]': 3 tests -----------------------------
Name (time in ns)                                                                     Mean             StdDev            OPS (Mops/s)          
-----------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0007_pgo)         223.6480 (1.0)      23.6122 (2.15)           4.4713 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0011_before)      239.4414 (1.07)     10.9777 (1.0)            4.1764 (0.93)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1000] (0003_changes)     275.3679 (1.23)     55.5576 (5.06)           3.6315 (0.81)   
-----------------------------------------------------------------------------------------------------------------------------------------------

----------------------------- benchmark 'test_di_graph_from_complete_graph_all_paths_array_chunks[100]': 3 tests -----------------------------
Name (time in ns)                                                                    Mean             StdDev            OPS (Mops/s)          
----------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0008_pgo)         266.1989 (1.0)      35.1826 (1.0)            3.7566 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0012_before)      274.3686 (1.03)     45.7569 (1.30)           3.6447 (0.97)   
test_di_graph_from_complete_graph_all_paths_array_chunks[100] (0004_changes)     273.1760 (1.03)     36.8990 (1.05)           3.6606 (0.97)   
----------------------------------------------------------------------------------------------------------------------------------------------

------------------------------ benchmark 'test_di_graph_from_complete_graph_all_paths_array_chunks[10]': 3 tests -------------------------------
Name (time in ns)                                                                   Mean                StdDev            OPS (Mops/s)          
------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0003_changes)     559.3960 (1.08)     2,725.5265 (2.31)           1.7876 (0.92)   
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0008_pgo)         515.9126 (1.0)      2,447.6062 (2.08)           1.9383 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[10] (0011_before)      549.1764 (1.06)     1,177.8927 (1.0)            1.8209 (0.94)   
------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------- benchmark 'test_di_graph_from_complete_graph_all_paths_array_chunks[1]': 3 tests -------------------------------
Name (time in ns)                                                                    Mean                StdDev            OPS (Kops/s)          
-------------------------------------------------------------------------------------------------------------------------------------------------
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0008_pgo)         1,112.3054 (1.0)        288.0466 (1.0)          899.0337 (1.0)    
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0003_changes)     1,268.3616 (1.14)     3,271.6523 (11.36)        788.4187 (0.88)   
test_di_graph_from_complete_graph_all_paths_array_chunks[1] (0011_before)      1,223.8266 (1.10)     1,999.6585 (6.94)         817.1092 (0.91)   
-------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

github-actions · 2024-09-17T14:24:22Z

Rust benchmark results:

group                                                       before                                 changes
-----                                                       ------                                 -------
complete_graph_all_paths/iter                               1.01     24.4±0.12ns 39.1 MElem/sec    1.00     24.2±1.19ns 39.4 MElem/sec
complete_graph_all_paths_array_chunks/1                     1.00     32.8±0.33ns 29.0 MElem/sec    1.01     33.3±0.28ns 28.6 MElem/sec
complete_graph_all_paths_array_chunks/10                    1.07   368.6±20.98ns 25.9 MElem/sec    1.00   344.4±11.08ns 27.7 MElem/sec
complete_graph_all_paths_array_chunks/100                   1.04      2.5±0.12µs 37.6 MElem/sec    1.00      2.4±0.01µs 39.3 MElem/sec
complete_graph_all_paths_array_chunks/1000                  1.00     22.3±0.21µs 42.7 MElem/sec    1.00     22.3±0.22µs 42.7 MElem/sec
di_graph_from_complete_graph_all_paths/iter                 1.01    226.9±2.49ns  4.2 MElem/sec    1.00    224.3±5.83ns  4.3 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1       1.00    235.9±5.55ns  4.0 MElem/sec    1.01    238.2±5.70ns  4.0 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/10      1.00      2.6±0.09µs  3.7 MElem/sec    1.00      2.6±0.04µs  3.7 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/100     1.02     23.4±0.55µs  4.1 MElem/sec    1.00     22.9±0.26µs  4.2 MElem/sec
di_graph_from_complete_graph_all_paths_array_chunks/1000    1.00    223.4±5.84µs  4.3 MElem/sec    1.03    229.1±3.69µs  4.2 MElem/sec

codecov · 2024-09-17T14:28:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (f14b08d) to head (74b0454).
Report is 121 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          20       20           
  Lines         845      847    +2     
=======================================
+ Hits          836      838    +2     
  Misses          9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-17T15:26:57Z

docs/source/notebooks/quickstart.ipynb

-    "scene = eqx.tree_at(lambda s: s.transmitters, scene, jnp.array([[8.5, 21, 27]]))\n",
-    "scene = eqx.tree_at(lambda s: s.receivers, scene, jnp.array([[45, 90, 1.5]]))\n",
-    "scene.plot()"
+    "# file = get_sionna_scene(\"etoile\")\n",


[LanguageTool] _{reported by reviewdog 🐶}
Unpaired symbol: ‘"’ seems to be missing (EN_UNPAIRED_QUOTES)
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-parentheses
Rule: https://community.languagetool.org/rule/show/EN_UNPAIRED_QUOTES?lang=en-US
Category: PUNCTUATION

feat(lib): enhance core library

a8a6437

jeertmans temporarily deployed to release September 17, 2024 14:17 — with GitHub Actions Inactive

github-actions bot added documentation Improvements or additions to documentation python Changes Python code rust Changes Rust code tests Changes tests labels Sep 17, 2024

fix(lib): object bounds and default scene

2c3200e

jeertmans temporarily deployed to release September 17, 2024 14:26 — with GitHub Actions Inactive

fix(lib): plotting support face_colors

450aa40

jeertmans temporarily deployed to release September 17, 2024 14:41 — with GitHub Actions Inactive

github-actions bot added the visualization Related to visualization utilities label Sep 17, 2024

fix(tests): better tests

74b0454

jeertmans temporarily deployed to release September 17, 2024 15:26 — with GitHub Actions Inactive

github-actions bot added ci Continuous integration (tests, lints, ...) dependencies labels Sep 17, 2024

github-actions bot reviewed Sep 17, 2024

View reviewed changes

jeertmans merged commit 0ad8c07 into main Sep 17, 2024
50 of 51 checks passed

jeertmans deleted the core branch September 17, 2024 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lib): enhance core library #115

feat(lib): enhance core library #115

jeertmans commented Sep 17, 2024

github-actions bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

codecov bot commented Sep 17, 2024 •

edited

Loading

github-actions bot Sep 17, 2024

feat(lib): enhance core library #115

feat(lib): enhance core library #115

Conversation

jeertmans commented Sep 17, 2024

github-actions bot commented Sep 17, 2024 • edited Loading

github-actions bot commented Sep 17, 2024 • edited Loading

codecov bot commented Sep 17, 2024 • edited Loading

Codecov Report

github-actions bot Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

codecov bot commented Sep 17, 2024 •

edited

Loading