Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get MCU1 and MCU2 of deye_sg04lp3 and improve temparature range for deye_2mppt #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions inverter/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
from inverter.exceptions import ValidationError
from inverter.validators import InverterValueValidator


logger = logging.getLogger(__name__)


Expand Down Expand Up @@ -159,8 +158,13 @@ def fetch_inverter_versions(
results = []
for info in infos:
print(f'Fetch "{info.name}"', end='...')
response: ModbusResponse = inv_sock.read(start_register=info.register, length=1)
if info.inverter == 'deye_sg04lp3':
response: ModbusResponse = inv_sock.read(start_register=info.register, length=2)
version = '-'.join(response.data_hex[i:i + 4] for i in range(0, len(response.data_hex), 4))
else:
response: ModbusResponse = inv_sock.read(start_register=info.register, length=1)
version = Version('.'.join(number for number in response.data_hex))

print(f'Result (in hex): [cyan]{response.data_hex}')
version = Version('.'.join(number for number in response.data_hex))
results.append(InverterRegisterVersionResult(info=info, data_hex=response.data_hex, version=version))
return results
16 changes: 11 additions & 5 deletions inverter/cli/cli_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -533,12 +533,18 @@ def inverter_version(ip, port, verbosity: int):
except ReadInverterError as err:
print(f'[red]{err}')
sys.exit(1)
if user_settings.inverter.name == 'deye_sg04lp3':
infos = [
InverterRegisterVersionInfo(name='MCU1', register=0x000E, inverter='deye_sg04lp3'),
InverterRegisterVersionInfo(name='MCU2', register=0x0011, inverter='deye_sg04lp3'),
]
else:
infos = [
InverterRegisterVersionInfo(name='Control Board Firmware', register=0x000D),
InverterRegisterVersionInfo(name='Communication Board Firmware', register=0x000E),
InverterRegisterVersionInfo(name='Communication Protocol', register=0x0012),
]

infos = [
InverterRegisterVersionInfo(name='Control Board Firmware', register=0x000D),
InverterRegisterVersionInfo(name='Communication Board Firmware', register=0x000E),
InverterRegisterVersionInfo(name='Communication Protocol', register=0x0012),
]
results = fetch_inverter_versions(inv_sock=inv_sock, infos=infos)

print_inverter_versions(results)
Expand Down
1 change: 1 addition & 0 deletions inverter/data_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ class Validators(msgspec.Struct):
class InverterRegisterVersionInfo:
name: str
register: int
inverter: str | None = None


@dataclasses.dataclass
Expand Down
2 changes: 1 addition & 1 deletion inverter/definitions/deye_2mppt_validations.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
validators:
- name: "Radiator Temperature"
type: "float"
min_value: -9.9
min_value: -99.9
max_value: 100

- name: "Total AC Output Power (Active)"
Expand Down
2 changes: 1 addition & 1 deletion inverter/utilities/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def print_inverter_versions(results: list[InverterRegisterVersionResult], title=
hex(result.info.register + offset), # Address (hex)
str(result.info.register + offset), # Address (dec)
result.data_hex, # Hex value
f'v{result.version}', # Human readable version
f'{result.version}', # Human readable version
)

console = get_console()
Expand Down