Skip to content

Commit

Permalink
Fix MyPy
Browse files Browse the repository at this point in the history
  • Loading branch information
jeckel committed Oct 17, 2024
1 parent 881452a commit c1c2a46
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 11 deletions.
8 changes: 8 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,11 @@ repos:
files: src/
types: [file, python]
args: [--max-line-length=131, --ignore, "F401"]

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.8.0
hooks:
- id: mypy
files: src/
types: [file, python]
# args: [--config-file=./.styleconfigs/mypy.ini]
5 changes: 2 additions & 3 deletions src/composer_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@ def composer_updatable(path: str) -> dict[str, str]:
stderr=subprocess.PIPE,
text=True,
) as process:
output = process.stderr.read().strip()
# Split the output into lines
lines = output.strip().split("\n")
stdout, stderr = process.communicate()
lines = stdout.strip().split("\n")
packages: dict[str, str] = {}

# Processing lines for packages
Expand Down
4 changes: 2 additions & 2 deletions src/models/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def name(self) -> str:
return os.path.basename(self.path)

@field_validator("path", mode="before")
def check_directory_exists(cls, v):
def check_directory_exists(cls, v) -> str:
if not os.path.isdir(v):
raise ValueError(f"Provided path '{v}' is not a valid directory.")
return v
Expand All @@ -32,5 +32,5 @@ def check_composer_file(self):
@cached_property
def composer_json(self) -> Optional[Composer]:
if not self.composer:
return
return None
return Composer.from_json(self.path)
14 changes: 8 additions & 6 deletions src/presentation/composer/composer_pan.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from textual import on, work
from textual.app import ComposeResult
from textual.containers import Container, Horizontal
from textual.widgets import TabPane
from textual.widgets import Button, TabPane
from textual.worker import Worker, WorkerState

from composer_utils import composer_updatable
Expand Down Expand Up @@ -41,16 +41,18 @@ async def refresh_listview(self, event: Worker.StateChanged) -> None:
"""Called when the worker state changes."""
if event.state == WorkerState.SUCCESS:
packages_updatable = event.worker.result
table: ComposerPackagesTable = self.query_one("#composer-packages-table")
table.set_requirements(
package_table: ComposerPackagesTable = self.query_one(
"#composer-packages-table"
)
package_table.set_requirements(
self.composer.required_packages,
self.composer.locked_packages,
packages_updatable,
)
table: ComposerPackagesTable = self.query_one(
package_dev_table: ComposerPackagesTable = self.query_one(
"#composer-packages-dev-table"
)
table.set_requirements(
package_dev_table.set_requirements(
self.composer.required_packages_dev,
self.composer.locked_packages_dev,
packages_updatable,
Expand All @@ -65,7 +67,7 @@ async def refresh_listview(self, event: Worker.StateChanged) -> None:
self.loading = False

@on(ComposerScriptButton.Pressed)
def on_pressed(self, event: ComposerScriptButton.Pressed) -> None:
def on_pressed(self, event: Button.Pressed) -> None:
if isinstance(event.button, ComposerScriptButton):
self.app.push_screen(
TerminalModal(
Expand Down

0 comments on commit c1c2a46

Please sign in to comment.