Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove shims directory in mise activate #3232

Merged
merged 3 commits into from
Nov 27, 2024
Merged

fix: remove shims directory in mise activate #3232

merged 3 commits into from
Nov 27, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Nov 27, 2024

Fixes #3230

Copy link

github-actions bot commented Nov 27, 2024

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main x -- echo 19.3 ± 0.7 17.8 23.6 1.01 ± 0.05
mise-2024.11.30 x -- echo 19.1 ± 0.6 17.8 20.9 1.00
mise x -- echo 19.6 ± 0.6 18.2 24.4 1.03 ± 0.04

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main env 15.6 ± 0.5 14.4 17.5 1.01 ± 0.05
mise-2024.11.30 env 15.5 ± 0.5 14.4 17.7 1.00
mise env 15.5 ± 0.5 14.5 16.9 1.00 ± 0.05

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main hook-env 15.6 ± 0.5 14.4 17.1 1.01 ± 0.05
mise-2024.11.30 hook-env 15.4 ± 0.6 14.3 18.8 1.00
mise hook-env 15.7 ± 0.5 14.4 17.4 1.02 ± 0.05

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main ls 13.0 ± 0.3 12.4 14.0 1.02 ± 0.03
mise-2024.11.30 ls 12.7 ± 0.3 12.1 14.1 1.00
mise ls 13.0 ± 0.3 12.5 14.2 1.02 ± 0.03

Copy link

codacy-production bot commented Nov 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-25.60% 70.59%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a530e44) 21867 15883 72.63%
Head commit (bfd5d8b) 42655 (+20788) 20061 (+4178) 47.03% (-25.60%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3232) 17 12 70.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jdx jdx merged commit 7de1111 into main Nov 27, 2024
24 checks passed
@jdx jdx deleted the rm-shims branch November 27, 2024 15:21
yami-beta added a commit to yami-beta/dotfiles that referenced this pull request Jan 15, 2025
mise のドキュメントに記載されている形に変更
実体は変更前と同様に `PATH` を通すため挙動に変わりはない

以前は `mise activate` の path 設定と shims 設定の両方を入れると warning が出ていた
以下の差分で `mise activate` が shims 設定を入れてある場合の対応が入ったことで共存できるようになった
jdx/mise#3232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mise env vs mise activate and duplicate PATH entries
1 participant