Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrectly displaying "cargo-" as tool versions instead of "cargo:" in mise ls #3029

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Nov 14, 2024

Fixes #3025

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% 77.78%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (341a6f1) 20826 16068 77.15%
Head commit (e4d177a) 20841 (+15) 16078 (+10) 77.15% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3029) 27 21 77.78%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jdx jdx merged commit 802967b into main Nov 14, 2024
14 of 15 checks passed
@jdx jdx deleted the aqua branch November 14, 2024 16:53
@glasser
Copy link
Contributor

glasser commented Nov 26, 2024

@jdx The combination of #3015 and this PR changed the behavior of status.show_tools so that instead of displaying the name you wrote in your config file (eg apollo-rover@0.26.2), it shows the expansion, eg ubi:apollographql/router@0.26.2. Was that intentional? (Note that when I try to bisect to understand exactly when this started, I actually can't run the mise created by any commit starting with #3015 until this one due to a panic.)

@jdx
Copy link
Owner Author

jdx commented Nov 26, 2024

not intentional, I've done a ton of work refactoring so that using the "short" (apollo-rover) and the "full" (ubi:apollographql/router) is more consistent in the codebase so it's not surprising this happened.

Most of the code before was written before these were different concepts (before backends) so there wasn't a distinction and over time a bunch of exceptions were added to resolve it when needed that had to go. Wherever the status is displayed probably just needs to switch from .to_string() or .full over to .short.

jdx added a commit that referenced this pull request Nov 26, 2024
jdx added a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Behavior with Installing and Uninstalling Tools Using ubi or aqua Backend
2 participants