Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kubelogin in registry? #3493

Closed
jimeh opened this issue Dec 12, 2024 · 2 comments · Fixed by #3534
Closed

Rename kubelogin in registry? #3493

jimeh opened this issue Dec 12, 2024 · 2 comments · Fixed by #3534

Comments

@jimeh
Copy link
Contributor

jimeh commented Dec 12, 2024

In mise's registry.toml, it sets up a kubelogin shorthand that installs Azure/kubelogin, which is a Microsoft Azure specific kubectl login helper.

But there's also int128/kubelogin, which is a generic OIDC kubectl authentication helper, and it has 1.8K stars on GitHub compared to just under 500 for Azure's kubelogin helper.

Hence, I'd like to suggest that the kubelogin shorthand is renamed to azure-kubelogin, and a new kubelogin shorthand is added for int128/kubelogin.

This is likely to be an unpopular change for anyone who's installed Azure's kubelogin tool however, so I don't think if renaming it is reasonable. Not to mention, since both tools expose an executable with the same name, it might be reasonable to add a "conflicts with" option of some kind in mise's registry, so that it doesn't let you activate both tools at the same time, or at least warns you about it.

@jdx
Copy link
Owner

jdx commented Dec 12, 2024

I think this is a rare case where it does make sense to rename it. It's not obvious what int128/kubelogin should be called and it's much more popular

@jdx
Copy link
Owner

jdx commented Dec 12, 2024

it'd be nice if #3339 was in because that would lock the backend into the lockfile, but even if I patched that now it still wouldn't help people until they reinstalled (and were already using lockfiles). I think we should stop the bleeding here despite that.

jdx added a commit that referenced this issue Dec 14, 2024
jdx added a commit that referenced this issue Dec 14, 2024
jdx added a commit that referenced this issue Dec 14, 2024
@jdx jdx closed this as completed in #3534 Dec 14, 2024
@jdx jdx closed this as completed in 9cf3c1c Dec 14, 2024
miguelmig pushed a commit to miguelmig/mise that referenced this issue Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants