Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for section_path in nav_repos #169

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

oleg-nenashev
Copy link

@oleg-nenashev oleg-nenashev commented Jan 8, 2025

Submitting for initial feedback

Currently, when using nav_repos, there is no possibility to specify a custom destination for the included repository. The slugify() command removes slashes and hence the directory tree. This patch copies the code from repos with a similar behavior.

When using such an approach, a site developer will have to be careful when specifying a path in nav

Copy link

github-actions bot commented Jan 8, 2025

Version Number Check

Version has been updated in pyproject.toml.

@jdoiro3
Copy link
Owner

jdoiro3 commented Jan 15, 2025

@oleg-nenashev, I just fixed some CI issues and merged main into your branch. CI should pass now. Let me know when you're ready for my review and thanks for contributing!

@oleg-nenashev
Copy link
Author

Hi. Sure, I would be happy to have this feature integrated If you find it feasible.

It still has certain limitations, because one cannot nest repositories just with that due to the parallel checkout. But it works pretty well otherwise in my PoC. For nesting, I think git submodules would be a preferred option anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants