Skip to content

Commit

Permalink
added sa_manifest and acr_manifest property, added sa and acr to mani…
Browse files Browse the repository at this point in the history
…fest names; added nsd to nsd manifest name
  • Loading branch information
Jordan committed Feb 21, 2024
1 parent b3d9f54 commit d6d8c56
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/aosm/azext_aosm/cli_handlers/onboarding_cnf_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def build_all_parameters_json(self) -> JSONDefinitionElementBuilder:
"publisherName": self.config.publisher_name,
"publisherResourceGroupName": self.config.publisher_resource_group_name,
"acrArtifactStoreName": self.config.acr_artifact_store_name,
"acrManifestName": self.config.acr_artifact_store_name + "-manifest",
"acrManifestName": self.config.acr_manifest_name,
"nfDefinitionGroup": self.config.nf_name,
"nfDefinitionVersion": self.config.version,
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def build_all_parameters_json(self) -> JSONDefinitionElementBuilder:
"publisherResourceGroupName": self.config.publisher_resource_group_name,
"acrArtifactStoreName": self.config.acr_artifact_store_name,
"saArtifactStoreName": self.config.blob_artifact_store_name,
"acrManifestName": self.config.acr_artifact_store_name + "-manifest",
"acrManifestName": self.config.acr_manifest_name,
"saManifestName": self.config.sa_manifest_name,
"nfDefinitionGroup": self.config.nf_name,
"nfDefinitionVersion": self.config.version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def build_all_parameters_json(self) -> JSONDefinitionElementBuilder:
"publisherName": self.config.publisher_name,
"publisherResourceGroupName": self.config.publisher_resource_group_name,
"acrArtifactStoreName": self.config.acr_artifact_store_name,
"acrManifestName": self.config.acr_artifact_store_name + "-manifest",
"acrManifestName": self.config.acr_manifest_name,
"nfDefinitionGroup": self.config.nf_name,
"nfDefinitionVersion": self.config.version
}
Expand Down
2 changes: 1 addition & 1 deletion src/aosm/azext_aosm/cli_handlers/onboarding_nsd_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def build_all_parameters_json(self) -> JSONDefinitionElementBuilder:
"publisherName": self.config.publisher_name,
"publisherResourceGroupName": self.config.publisher_resource_group_name,
"acrArtifactStoreName": self.config.acr_artifact_store_name,
"acrManifestName": self.config.acr_artifact_store_name + "-manifest",
"acrManifestName": self.config.acr_manifest_name,
"nsDesignGroup": self.config.nsd_name,
"nsDesignVersion": self.config.nsd_version,
"nfviSiteName": self.nfvi_site_name,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ class OnboardingNFDBaseInputConfig(OnboardingBaseInputConfig):
},
)

@property
def acr_manifest_name(self) -> str:
"""Return the Storage account manifest name from the NFD name."""
sanitized_acr_name = self.acr_artifact_store_name.lower().replace("_", "-")
return f"{sanitized_acr_name}-acr-manifest-{self.version.replace('.', '-')}"

def validate(self):
"""Validate the configuration."""
super().validate()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,12 @@ class OnboardingNSDInputConfig(OnboardingBaseInputConfig):
)
)

@property
def acr_manifest_name(self) -> str:
"""Return the Storage account manifest name from the NFD name."""
sanitized_acr_name = self.acr_artifact_store_name.lower().replace("_", "-")
return f"{sanitized_acr_name}-nsd-manifest-{self.nsd_version.replace('.', '-')}"

def validate(self):
"""Validate the configuration."""
super().validate()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def __post_init__(self):
@property
def sa_manifest_name(self) -> str:
"""Return the Storage account manifest name from the NFD name."""
return f"{self.blob_artifact_store_name}-manifest-{self.version.replace('.', '-')}"
return f"{self.blob_artifact_store_name}-sa-manifest-{self.version.replace('.', '-')}"

def validate(self):
"""Validate the configuration."""
Expand Down

0 comments on commit d6d8c56

Please sign in to comment.