Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feats: adds options interface for MergeRequest.all() #606

Merged
merged 2 commits into from
Apr 26, 2020
Merged

feats: adds options interface for MergeRequest.all() #606

merged 2 commits into from
Apr 26, 2020

Conversation

AlvaroBernalG
Copy link
Contributor

@AlvaroBernalG AlvaroBernalG changed the title Adds options interface for MergeRequest.all() feats: adds options interface for MergeRequest.all() Feb 15, 2020
@AlvaroBernalG AlvaroBernalG force-pushed the mergeRequest-all-interface branch from 2c2850a to bfe7849 Compare February 15, 2020 18:08
jetersen
jetersen approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdalrymple
Copy link
Owner

I know its a pain, but could you also add the type information for the camelCased response. Similar to here: https://github.com/jdalrymple/gitbeaker/blob/gitbeaker-release/packages/gitbeaker-core/src/services/Groups.ts

@AlvaroBernalG
Copy link
Contributor Author

AlvaroBernalG commented Feb 16, 2020 •
edited
Loading

I know its a pain, but could you also add the type information for the camelCased response. Similar to here: https://github.com/jdalrymple/gitbeaker/blob/gitbeaker-release/packages/gitbeaker-core/src/services/Groups.ts

Sure 👍,

Thanks to @MariusAlch with his https://github.com/MariusAlch/json-to-ts it's going to be a bit less painful 😄

@jdalrymple jdalrymple force-pushed the master branch 2 times, most recently from 8751ae6 to d9c97d4 Compare March 22, 2020 17:39
@jdalrymple jdalrymple force-pushed the mergeRequest-all-interface branch from bfe7849 to 6528399 Compare April 26, 2020 16:17
@jdalrymple jdalrymple merged commit ad942b3 into jdalrymple:master Apr 26, 2020
@jdalrymple
Copy link
Owner

🚀 PR was released in 19.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvaroBernalG @jdalrymple @jetersen