Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet Dependencies #105

Closed
jcurl opened this issue May 6, 2020 · 2 comments
Closed

NuGet Dependencies #105

jcurl opened this issue May 6, 2020 · 2 comments
Labels

Comments

@jcurl
Copy link
Owner

jcurl commented May 6, 2020

Raised by https://github.com/romerod in ticket #104.

The nuget package shows depencendencies for 4.6.2.

The empty group "<group targetFramework=".NETFramework4.6.2" />" is missing.

2.2.0 package:

<dependencies>
      <group targetFramework=".NETFramework4.6.2" />
      <group targetFramework=".NETStandard1.5">
        <dependency id="System.Threading.Overlapped" version="4.3.0" />
        <dependency id="System.Threading.Thread" version="4.3.0" />

2.2.1 package:

<dependencies>
      <group targetFramework=".NETStandard1.5">
        <dependency id="System.Threading.Overlapped" version="4.3.0" />
        <dependency id="System.Threading.Thread" version="4.3.0" />
@jcurl
Copy link
Owner Author

jcurl commented May 6, 2020

The sources for label 2.2.0 and 2.2.1 don't contain the empty group for .NET 4.6.2. This must have been automatically added somewhere.

I downloaded the version from the "assets" for the release here in GitHub, and it doesn't contain the empty group either.

What's the side effect of the missing 4.6.2? Does it pull in unexpected dependencies? If so, I should do a rerelease, in which case I'll open a new ticket, so I can reference it in the commit history.

Retested with NuGet 5.11 and it didn't add the empty 4.6.2 dependency either (but complained there was a missing net40 and net45 dependency, see below). At least I should probably fix that (there are no dependencies that I'm aware of).

WARNING: NU5125: The 'licenseUrl' element will be deprecated. Consider using the 'license' element instead.
WARNING: NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
- Add a dependency group for .NETFramework4.0 to the nuspec
- Add a dependency group for .NETFramework4.5 to the nuspec

jcurl added a commit that referenced this issue May 6, 2020
@jcurl
Copy link
Owner Author

jcurl commented May 6, 2020

I've uploaded here the generated packages for testing.
serialportstream.zip

@jcurl jcurl added the bug label May 8, 2020
@jcurl jcurl closed this as completed May 8, 2020
jcurl added a commit that referenced this issue May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant