Only notifies ConfigMap updates if data changes #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConfigMap now can be used as the IngressClass' Parameters target. Because of that ConfigMaps in the controller namespace are also being watched. However other ConfigMaps that changes periodically was starting the ingress parsing - eg the cm used for leader election which is update every few seconds. This update checks if a ConfigMap's data attribute was changed, otherwise a reconciliation isn't started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigMap now can be used as the IngressClass' Parameters target. Because of that ConfigMaps in the controller namespace are also being watched. However other ConfigMaps that changes periodically was starting the ingress parsing - eg the cm used for leader election which is update every few seconds.
This update checks if a ConfigMap's data attribute was changed, otherwise a reconciliation isn't started.