Fix duplication of userlist #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A basic auth's userlist can be reused if the same password secret is reused in more than one Ingress, or even on the same Ingress with two or more paths. The userlist was being duplicated due to a missing find func. This doesn't break the configuration because all the userlists have the same content and haproxy complains but doesn't refuse to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic auth's userlist can be reused if the same password secret is reused in more than one Ingress, or even on the same Ingress with two or more paths. The userlist was being duplicated due to a missing find func. This doesn't break the configuration because all the userlists have the same content and haproxy complains but doesn't refuse to start.