Add session-cookie-keywords #601
Merged
+46
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to configure the cookie options in more detail. This might be necessary to let the backend server access the affinity cookie or to turn off the `httponly` flag. The default value is still `indirect nocache httponly` to be backwards compatible.
|
Closes #566 |
jcmoraisjr
reviewed
Jun 14, 2020
| @@ -198,6 +198,7 @@ The table below describes all supported configuration keys. | |||
| | [`session-cookie-name`](#affinity) | cookie name | Backend | | | |||
| | [`session-cookie-shared`](#affinity) | [true\|false] | Backend | `false` | | |||
| | [`session-cookie-strategy`](#affinity) | [insert\|prefix\|rewrite] | Backend | | | |||
| | [`session-cookie-keywords`](#affinity) | cookie options | Backend | `indirect nocache httponly` | | |||
| | `session-cookie-name` | `Backend` | `INGRESSCOOKIE` | | | ||
| | `session-cookie-shared` | `Backend` | `false` | v0.8 | | ||
| | `session-cookie-strategy` | `Backend` | `insert` | | | ||
| | `session-cookie-keywords` | `Backend` | `indirect nocache httponly` | v0.11 | |
| @@ -353,6 +355,7 @@ Configure if HAProxy should maintain client requests to the same backend server. | |||
| * `session-cookie-strategy`: the cookie strategy to use (insert, rewrite, prefix). `insert` is the default value if not declared. | |||
| * `session-cookie-shared`: defines if the persistence cookie should be shared between all domains that uses this backend. Defaults to `false`. If `true` the `Set-Cookie` response will declare all the domains that shares this backend, indicating to the HTTP agent that all of them should use the same backend server. | |||
| * `session-cookie-dynamic`: indicates whether or not dynamic cookie value will be used. With the default of `true`, a cookie value will be generated by HAProxy using a hash of the server IP address, TCP port, and dynamic cookie secret key. When `false`, the server name will be used as the cookie name. Note that setting this to `false` will have no impact if [use-resolver](#dns-resolvers) is set. | |||
| * `session-cookie-keywords`: options to the `cookie` option like `nocache`, `preserve`, `httponly`. `indirect nocache httponly` is the default if not declared to be backwards compatible to earlier versions. | |||
There was a problem hiding this comment.
add a reference to the default value only if insert strategy is used.
try also to rephrase the last sentence to something like "the default is ..." in order to separate the former list of keywords to the later one.
| @@ -110,6 +110,7 @@ const ( | |||
| BackSessionCookieName = "session-cookie-name" | |||
| BackSessionCookieShared = "session-cookie-shared" | |||
| BackSessionCookieStrategy = "session-cookie-strategy" | |||
| BackSessionCookieKeywords = "session-cookie-keywords" | |||
|
Merging, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to configure the cookie options in more detail.
This might be necessary to let the backend server access the affinity cookie
or to turn off the
httponlyflag.The default value is still
indirect nocache httponlyto be backwardscompatible.