Remove frontend group #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A frontend+bind list were historically used to separate distinct client timeouts, distinct `ca-file` if auth-tls is used, and also distinct hostnames in pre-historical versions. Client timeout was just moved to global scope, which allows to use a single frontend and a single bind config despite the ingress and controller configuration. This update doesn't have any functional change - it is merely removing the legacy code used to build a list of frontends with a list of binds. Such simplifications will speedup the development of performance tunings. A L6 frontend is still needed and only configured if at least one hostname uses ssl-passthrough. TCP services wasn't changed and will continue to be configured as usual.
f91e0a9 to
bc03215
Compare
Frontend group was used to group all frontends, binds and their related map files into a single entity. The need of a list of frontends doesn't exist anymore, so all inner entities and funcs are being moved. This change creates a frontend entity in the root haproxy config and implement some funcs being removed from the frontendGroup.
Another step on behalf of remove responsibility from the frontendGroup: create a new entity responsible for manage all hostnames, either ssl-passthrough and HTTP/L7.
Frontend group building used to make a lot of stuff, including changes to the model state. Moving only the state changing calls improves cohesion, which will also improve maintainability.
Frontend group was converted to a link of maps after the last changes. This update renames the func and the old frontend group entity, and also moves the maps link to the frontend entity. The new `Write(Frontend|Backend)Maps()` funcs doesn't change the model state and should continue like this.
bc03215 to
84d85ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend group was used to group all frontends, binds and their related map files into a single entity. The need of a list of frontends doesn't exist anymore, so all inner entities and funcs are being moved on behalf of simplicity and cohesion, which will simplify future improvements. Further details in the message of the commits. There are no functionality changes.