use the found match pattern #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string `_nomatch` was used everywhere as a fallback if some pattern isn't found in a map. This used to work nice provided that the source sample could be found. There is however a special use case when the sni extension isn't provided and the domain has optional client cert: the response is 404 due to the fetch sample failed. This doesn't affect v0.8 because the failed sample is new in v0.9 - see concat(). This change removes the default value on map*() converters, so it can fail, won't create the target variable and `-m found` can be used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string
_nomatchwas used everywhere as a fallback if some pattern isn't found in a map. This used to work nice provided that the source sample could be found.There is however a special use case when the sni extension isn't provided and the domain has optional client cert: the response is 404 due to the fetch sample failed. This doesn't affect v0.8 because the failed sample is new in v0.9 - see concat().
This change removes the default value on map*() converters, so it can fail, won't create the target variable and
-m foundcan be used instead.