Add support for Mod Security DetectionOnly Mode #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@serpro.gov.br>
jcmoraisjr
reviewed
Nov 10, 2019
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@serpro.gov.br>
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@serpro.gov.br
This PR adds support for a DetectionOnly mode in Mod Security for each backend.
The idea here is when specifying the annotation 'waf-mode: "DetectionOnly"' it will send the requests to the ModSecurity filter to generate the appropriate logging, but no action will be taken.
To keep the compability with following versions, the behavior here is: if there's a
wafannotation and nowaf-modeannotation, it will block bad requests.To enable DetectionOnly mode user must create the
waf-modeannotation with DetectionOnly as its value