Fix duplication of ConfigFrontend snippets for DefaultBackend #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where any frontend configuration is duplicated twice for the default backend, e.g. config-frontend in the ConfigMap of `http-response add-header my-header` results in two headers `my-header` in the response from the default backend
|
Hi, good catch. Makes sense since the default backend is always behind another frontend, hence the duplication. Merging and cherry-picking to v0.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where any frontend configuration is duplicated twice for the default backend.
Example for a
config-frontendin the ConfigMap ofhttp-response add-header my-headerresults in two headersmy-headerin the response from the default backend.This is particularly bad when forcing http to https redirection using
config-frontendwe were seeing an infinite loop of redirects for unknown ingress endpoints rather than a 404.