Allow hostname (e.g., k8s pod name) to be used as the cookie value. #286
Conversation
aa51835 to
67d9a89
Compare
|
Rebased to master, but would like this to go in the 0.7 release if that's possible. |
There was a problem hiding this comment.
Hi, thanks again for supporting this controller. Following a few suggestions.
This PR is somewhat big and v0.7 is being stabilized. I cannot merge these changes, sorry. Otoh v0.8 will have a very little impact with new features if using with v0.7 controller - v0.8 has most of the controller rewritten from scratch and v0.7 implementation and updates will be available. About a month from now I hope to start v0.8 snapshots which will have a very stable v0.7 controller with your changes and almost nothing more. Hope this helps.
That's a bummer, but if it's at least included in the next release, I can stop maintaining a fork eventually. |
67d9a89 to
884ef7d
Compare
|
Merging, thanks!
I'm doing my best on behalf of stability. I need to draw the line somewhere otherwise we wouldn't have a stable release. What I'm planning to do from now is to release often, this should also help to see new code on stable images earlier. |
For my use case, it is useful to have the kubernetes pod name come through in the cookie value (it makes some debugging tasks easier). This pull request adds an annotation that allows the behavior of the dynamic cookie to be turned off if DNS server resolving isn't in use.
I also fixed some problems with log messages that the go 1.11 compiler warned me about.