Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigMap: add options to set ssl-engine and ssl-mode-async #269

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Dec 18, 2018

Some deployments may have the access to an OpenSSL engine to benefit
from, e.g., TLS offloading to a hardware engine.

Add new ConfigMap options to be able to more easily configure HAproxy
to use the engines available.

Some deployments may have the access to an OpenSSL engine to benefit
from, e.g., TLS offloading to a hardware engine.

Add new ConfigMap options to be able to more easily configure HAproxy
to use the engines available.
@bedis
Copy link

bedis commented Dec 21, 2018

This is a wonderful feature, allowing HAProxy to benefit from HW accelerated devices for SSL processing.
+1

@jcmoraisjr
Copy link
Owner

Nice, thanks! Merging.

Note however that this same feature can also be used right now (since v0.7) configuring ssl-engine and ssl-mode-async with config-global configmap option.

@jcmoraisjr jcmoraisjr merged commit 63a4be3 into jcmoraisjr:master Jan 6, 2019
@jcmoraisjr jcmoraisjr added this to the v0.8 milestone Jan 6, 2019
@mythi
Copy link
Contributor Author

mythi commented Jan 7, 2019

@jcmoraisjr thanks! I learnt about config-global after I had my patch implemented. I believe the engine feature is more visible this way and helps to increase the adoption.

@jcmoraisjr
Copy link
Owner

Hi @mythi , just saw your blog post. Thanks for choosing HAProxy and haproxy-ingress!

@mythi
Copy link
Contributor Author

mythi commented Apr 25, 2019

@jcmoraisjr sure thing, it was the most straightforward path to enable the use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants