Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish-service documentation #211

Merged
merged 2 commits into from
Sep 29, 2018

Conversation

danigrmartinez
Copy link
Contributor

I am running v0.6-beta.3 in AWS, k8s 1.9 and external-dns. It is perfectly working. I hope were in the documentation to save time the next person. 👍

Related to this issue #93

I am running v0.6-beta.3 in AWS, k8s 1.9 and external-dns. It is perfectly working. I hope were in the documentation to save time the next person. 👍 

Related to this issue jcmoraisjr#93
@jcmoraisjr
Copy link
Owner

Great, thanks! Just a few changes before merging:

  • Include in alphabetical order
  • Remove [0]

Using alphabetic order and removing '[0]' us reviewers suggested
@danigrmartinez
Copy link
Contributor Author

@jcmoraisjr Done 👍

@jcmoraisjr
Copy link
Owner

Merging, tks!

@jcmoraisjr jcmoraisjr merged commit 322fb08 into jcmoraisjr:master Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants