Fix redirect https if path changed with rewrite-target

[jcmoraisjr]

Fix redirect-https if used with rewrite-target.

Option 1 (current): use an acl so reqrep will only execute if redirect https isn't executed
Option 2: write the whole new location using txn.path instead of redirect https

Fixes #178 .

[qwylz]

Thanks for quickly addressing this (and thanks for a generally great ingress, too!).

I had a look at the patched template. It fixes the issue when the specific ingress has ssl-redirect enabled, but not when that is the default.

Don't we need something like the following (only showing one of the modified reqrep lines)?

reqrep ^([^\ :]*)\ {{ $location.Path }}/?(.*$) \1\ {{ $rewriteTarget }}\2 if {{ if $server.SSLRedirect }}from-https {{ else }}{{ if $location.SSLRedirect }}from-https {{ end }}{{end}}{{ $server.ACLLabel }} { var(txn.path) -m beg {{ $location.Path }} }

[jcmoraisjr]

Indeed. What about server or location inside the same if statement?

[jcmoraisjr]

... but not when that is the default

Indeed. What about server or location inside the same if statement?

Reverting ... $location actually inherit the default configuration. Did you see any issue with default ssl-redirect config?

[qwylz]

Ha! You're right. I didn't realize that and was making assumptions based on other parts of the template file that tested whether ssl redirection was enabled at the server level and location level separately. 84fd631 works correctly. :-)