Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long FQDN is breaking haproxy configuration #112

Closed
tlopo opened this issue Mar 9, 2018 · 7 comments
Closed

Long FQDN is breaking haproxy configuration #112

tlopo opened this issue Mar 9, 2018 · 7 comments
Milestone

Comments

@tlopo
Copy link

tlopo commented Mar 9, 2018

We are using bind unix@/var/run/haproxy-host-<FQDN> ssl crt <CERT_PATH> but that socket
path is limited to 107 chars:

<path>        is a UNIX socket path beginning with a slash ('/'). This is
              alternative to the TCP listening port. Haproxy will then
              receive UNIX connections on the socket located at this place.
              The path must begin with a slash and by default is absolute.
              It can be relative to the prefix defined by "unix-bind" in
              the global section. Note that the total length of the prefix
              followed by the socket path cannot exceed some system limits
              for UNIX sockets, which commonly are set to 107 characters.

We could use use md5 hash of FQDN to avoid this, or perhaps service name.

That should be a simple change here and here

jcmoraisjr added a commit that referenced this issue Mar 10, 2018
@jcmoraisjr
Copy link
Owner

Hi, since b2beccc all sockets with about 100+ chars will use a md5 hash instead it's name. The svc name would be nice too but there isn't a 1<->1 relation between sockets and svcs. Thanks for sharing this issue!

@jcmoraisjr jcmoraisjr added this to the v0.6 milestone Mar 10, 2018
@tlopo
Copy link
Author

tlopo commented Mar 10, 2018

@jcmoraisjr Thanks for the quick fix!

@tlopo
Copy link
Author

tlopo commented Mar 14, 2018

@jcmoraisjr could you please tag this commit so an image is created? Thanks in advance

@jcmoraisjr
Copy link
Owner

I've just pushed a100bb1 to quay.io/jcmoraisjr/haproxy-ingress:v0.6-a100bb1. I have a few new feature to finish before starting snapshot tags. Note that there are some new simple features and HAProxy was updated to 1.8. Let me know if you have any problem.

jcmoraisjr added a commit that referenced this issue Mar 16, 2018
@jcmoraisjr
Copy link
Owner

Cherry picked to v0.5, please have a look if canary tag is working for you.

@jcmoraisjr jcmoraisjr modified the milestones: v0.6, v0.5 Mar 16, 2018
@tlopo
Copy link
Author

tlopo commented Mar 26, 2018

v0.5-beta.3 is working fine for me. thank you!

@jcmoraisjr
Copy link
Owner

Tks! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants