Fix error message on incorrect regexp #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mx-psi
commented
Oct 19, 2021
- Move regex list creation code to separate function (to be used on Add support for skipping based on directories #13 impl)
- Fix error message when compiling a regex
jcchavezs
reviewed
Oct 19, 2021
cmd/porto/main.go
Outdated
| @@ -12,6 +12,21 @@ import ( | |||
| "github.com/jcchavezs/porto" | |||
| ) | |||
|
|
|||
| func getRegexpList(flagVal string) ([]*regexp.Regexp, error) { | |||
There was a problem hiding this comment.
nit: I'd rather call it regexps string, flagVal sounds like unnecessary detail. regexpsCommaSeparated could also work.
There was a problem hiding this comment.
Do you mind covering it with a simple unit test?
There was a problem hiding this comment.
Do you mind covering it with a simple unit test?
Added and moved to regexes.go (felt weird to have unit tests under cmd/)
|
Thanks a lot for the contribution. I added some comments. |
jcchavezs
reviewed
Oct 20, 2021
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestGetRegexpList(t *testing.T) { |
jcchavezs
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.