Cater to legacy handlers

Relates to quarkusio/quarkus#22844
jboss-logging · Nov 28, 2023 · d34ac96 · d34ac96
1 parent 393579f
commit d34ac96
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/src/main/java/org/jboss/logmanager/LoggerNode.java b/src/main/java/org/jboss/logmanager/LoggerNode.java
@@ -40,6 +40,7 @@
 import java.util.logging.Filter;
 import java.util.logging.Handler;
 import java.util.logging.Level;
+import java.util.logging.LogRecord;
 
 import io.smallrye.common.constraint.Assert;
 import io.smallrye.common.ref.PhantomReference;
@@ -428,10 +429,26 @@ void setUseParentHandlers(final boolean useParentHandlers) {
         }
     }
 
+    @SuppressWarnings("deprecation") // record#getFormattedMessage
     void publish(final ExtLogRecord record) {
+        LogRecord oldRecord = null;
         for (Handler handler : getHandlers())
             try {
-                handler.publish(record);
+                if (handler instanceof ExtHandler) {
+                    handler.publish(record);
+                } else {
+                    // old-style handlers generally don't know how to handle printf formatting
+                    if (oldRecord == null) {
+                        if (record.getFormatStyle() == ExtLogRecord.FormatStyle.PRINTF) {
+                            // reformat it in a simple way, but only for legacy handler usage
+                            oldRecord = new ExtLogRecord(record);
+                            oldRecord.setMessage(record.getFormattedMessage());
+                        } else {
+                            oldRecord = record;
+                        }
+                    }
+                    handler.publish(oldRecord);
+                }
             } catch (VirtualMachineError e) {
                 throw e;
             } catch (Throwable t) {