Pmd7 avoid unused assignments

[stokpop]

This is the last PMD7 rule to migrate, work in progress, need help :-)

Not ready to merge yet!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stokpop]

Also tried something like this, to see if next usage is before the next assignment:

for $node in //Block//ExpressionStatement/AssignmentExpression
   return $node[
     let $nextAssignment := following::ExpressionStatement/AssignmentExpression/VariableAccess[$node//VariableAccess/@Name = @Name][1],
         $nextUse := following::ExpressionStatement//(MethodCall|UnaryExpression)/VariableAccess[$node//VariableAccess/@Name = @Name][1]
     return 
       let $nextAssignmentPos := $nextAssignment/../position(), $nextUsePos := $nextUse/../position() 
       return $nextAssignmentPos > $nextUsePos
   ]