Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate java rules to pmd 7.x.x #309

Closed
emouty opened this issue May 14, 2024 · 3 comments
Closed

Migrate java rules to pmd 7.x.x #309

emouty opened this issue May 14, 2024 · 3 comments
Assignees
@jborgers

Comments

@emouty
Copy link

emouty commented May 14, 2024

Because of breaking changes introduced with pmd 7.x.x, the java ruleset can't be used with this new version.

The main error I've seen is from the package migration of net.sourceforge.pmd.lang.rule.XPathRule to net.sourceforge.pmd.lang.rule.xpath.XPathRule, but there could be other errors.

It could be nice to migrate the rulesets to be compatible with this new major version
@jborgers jborgers self-assigned this May 14, 2024
@jborgers
Copy link
Owner

Hi, thanks for reporting. We are aware of it. This needs quite some time to migrate the rules to 7. We are figuring out how to do this.

@jborgers jborgers mentioned this issue Jun 24, 2024
Closed
@jborgers jborgers changed the title Update java rules to pmd 7.x.x Migrate java rules to pmd 7.x.x Jul 25, 2024
@jborgers
Copy link
Owner

jborgers commented Jul 25, 2024 •
edited
Loading

The AST provided by PMD7 is incompatible with the one of PMD6. It actually has a lot of structural changes. The xpath expression of each rule needs to be migrated.

Working on branch pmd7-upgrade-7.2.0

jborgers added a commit that referenced this issue Jul 25, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: 3 rules migrated, number 2, 3 a…
4655806 
…nd 4: AvoidConstantsInInterface, AvoidDecimalAndChoiceFormatAsField, AvoidDuplicateAssignmentsInCases
jborgers added a commit that referenced this issue Jul 26, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: 1 complex rule migrated, number…
96c3091 
… 5: AvoidImplicitlyRecompilingRegex
jborgers added a commit that referenced this issue Jul 29, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: 1 rule migrated, number 6: Avoi…
3d9a9e3 
…dInMemoryStreamingDefaultConstructor
jborgers added a commit that referenced this issue Aug 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: 1 rule migrated, number 7: Avoi…
caf785b 
…dMultipleConcatStatements
jborgers added a commit that referenced this issue Aug 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: AvoidMultipleConcatStatements a…
af10734 
…dded example
jborgers added a commit that referenced this issue Aug 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 8: AvoidRecompiling…
93bbcdc 
…Patterns
jborgers added a commit that referenced this issue Aug 2, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 9: AvoidRecompiling…
c929518 
…XPathExpression
jborgers added a commit that referenced this issue Aug 2, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 10: AvoidRecreating…
dde8c01 
…DateTimeFormatter
jborgers added a commit that referenced this issue Aug 8, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 11: AvoidReflection…
3874c9a 
…InToStringAndHashCode
jborgers added a commit that referenced this issue Aug 8, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 12: AvoidSimpleDate…
6019129 
…Format
jborgers added a commit that referenced this issue Aug 8, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 13: AvoidStringBuffer
f428a44
jborgers added a commit that referenced this issue Aug 9, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 14: AvoidUnconditio…
b066a1f 
…nalBuiltLogStrings
jborgers added a commit that referenced this issue Aug 9, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 15: AvoidWideScopeX…
cb9533a 
…PathExpression
jborgers added a commit that referenced this issue Aug 9, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 16: AvoidXPathAPIUsage
f9ab927
jborgers added a commit that referenced this issue Aug 9, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 16: AvoidXPathAPIUs…
32b048f 
…age - completion
jborgers added a commit that referenced this issue Aug 9, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 17: AvoidXPathUsage
6c3372d
jborgers added a commit that referenced this issue Aug 12, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 18: MDCPutWithoutRe…
fbdb9a4 
…move
jborgers added a commit that referenced this issue Aug 12, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 19: UnconditionalCo…
cc4454f 
…ncatInLogArgument
jborgers added a commit that referenced this issue Aug 13, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 20: UnconditionalOp…
867f819 
…erationOnLogArgument
jborgers added a commit that referenced this issue Aug 15, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 21: UnconditionalCr…
e58d574 
…eatedLogArguments
jborgers added a commit that referenced this issue Aug 15, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: rule number 22+23: UsingSuppres…
9f261f0 
…sWarnings and UsingSuppressWarningsHighRisk
jborgers added a commit that referenced this issue Aug 30, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309:
9b217de 
rule number 24: AvoidTimeUnitConfusion
jborgers added a commit that referenced this issue Sep 2, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309:
3637188 
rule number 25: FieldOfHashCodeMissingInEquals
jborgers added a commit that referenced this issue Sep 2, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309:
6aecbe3 
rule number 25: MissingFieldInEquals
jborgers added a commit that referenced this issue Sep 2, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309:
c3d2bfc 
rule number 27: MissingFieldInHashCode
stokpop added a commit that referenced this issue Oct 20, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - AvoidModelMapAsRenderP…
20940eb 
…arameter
stokpop added a commit that referenced this issue Oct 20, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - AvoidSpringApplication…
103f13a 
…ContextRecreation
stokpop added a commit that referenced this issue Oct 21, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - AvoidSpringMVCMemoryLeaks
96a7c9b
stokpop added a commit that referenced this issue Oct 21, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - MakeAutoWiredConstruct…
2f54702 
…edFieldFinal
stokpop added a commit that referenced this issue Oct 22, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - MinimizeActionModelMap…
75e4fac 
…InSession
stokpop added a commit that referenced this issue Oct 22, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - added examples
906d1fe
jborgers added a commit that referenced this issue Oct 23, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: remoting - PR comment: HttpClie…
9a84347 
…ntBuilderWithoutPoolSize typo
stokpop added a commit that referenced this issue Oct 29, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - AvoidExpressionsInCach…
0a2fb9c 
…eable
stokpop added a commit that referenced this issue Oct 29, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - SynchronizeForKeyInCac…
2fdc2e2 
…heable
stokpop added a commit that referenced this issue Oct 29, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - AvoidSimpleCaches
0c7b7f4
stokpop added a commit that referenced this issue Oct 29, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - AvoidIdentityCacheKeys
177b627
stokpop added a commit that referenced this issue Oct 29, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - UseExplicitKeyGenerato…
143a310 
…rForCacheable
stokpop added a commit that referenced this issue Oct 29, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - AvoidSimpleKeyCollisions
ef70245
stokpop added a commit that referenced this issue Oct 29, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - EnsureProperCacheableP…
ec75718 
…arams
stokpop added a commit that referenced this issue Oct 29, 2024
@stokpop
Migrate java rules to pmd 7.x.x #309: spring - UseClearKeyGeneratorName
3fec65f
jborgers added a commit that referenced this issue Oct 30, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: sql - AvoidFetchingWholeList
e88a2b6
jborgers added a commit that referenced this issue Oct 30, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: sql - AvoidFetchingWholeList - …
125f889 
…support jakarta.persistence
jborgers added a commit that referenced this issue Oct 30, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: sql - AvoidHugeQueryFetchSize
95c0733
jborgers added a commit that referenced this issue Oct 31, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: sql - AvoidHugeQueryFetchSize -…
54cd263 
… processed PR comments
jborgers added a commit that referenced this issue Oct 31, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: sql - AvoidMultipleRoundtripsFo…
fda5a1d 
…rQuery
jborgers added a commit that referenced this issue Nov 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: sql - AvoidSqlInExpression
e2b9d47
jborgers added a commit that referenced this issue Nov 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: sql - AvoidSqlInExpression - re…
761e9fd 
…moved empty sql dirs
jborgers added a commit that referenced this issue Nov 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: sql - AvoidSqlInExpression - PR…
2482c9b 
… comments
jborgers added a commit that referenced this issue Nov 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: sql - AvoidSqlInExpression - fi…
2c3af8a 
…x line numbers in unit test
jborgers added a commit that referenced this issue Nov 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: merge non-tag changes from mast…
58fa1f4 
…er upto (incl) 18/7
jborgers added a commit that referenced this issue Nov 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: merge non-tag changes from mast…
6485404 
…er: MissingEqualsAndHashCodeWithGetterSetter incl all fixes
jborgers added a commit that referenced this issue Nov 1, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: merge non-tag changes from mast…
3a81895 
…er: README and LICENSE updates
jborgers added a commit that referenced this issue Nov 4, 2024
@jborgers
Migrate java rules to pmd 7.x.x #309: publish jpinpoint-rules.xml for…
92c66c5 
… pmd7
@jborgers
Copy link
Owner

Migration is done, except for #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jborgers jborgers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emouty @jborgers