Pytorch 1.8 and 1.9 compatibility #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2f0005 to
0002278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version should be compatible with multiple PyTorch versions (it works at least on 1.6.0, 1.7.1, 1.8.1, 1.9.0).
This fix is based on suggestions from this comment zh217#15 (comment) by @SunnerLi and on existing but not fully working PR zh217#21 by @underdogliu.
My version does not use version checking during execution of dct calculation. Instead it tries to import new
torch.fftmodule and conditionally defines three functions using either new or old implementation of FFT. This is done only once, when module is imported.