Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal IMetadataSymbolWriter that prevents external composition of symbol writers #564

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Remove internal IMetadataSymbolWriter that prevents external composition of symbol writers #564

merged 2 commits into from
Jan 29, 2019

Conversation

jbevain
Copy link
Owner

@jbevain jbevain commented Jan 29, 2019 •
edited
Loading

This fixes scenarios where we the user wants to provide its own ISymbolWriterProvider and own ISymbolWriter that wraps Cecil's ISymbolWriter implementation, as in:

#554 (comment)

@jbevain jbevain mentioned this pull request Jan 29, 2019
Closed
@jbevain jbevain force-pushed the remove-imetadatasymbolwriter branch from 4fa46e4 to 2768554 Compare January 29, 2019 07:59
@jbevain jbevain merged commit 5178d70 into master Jan 29, 2019
@jbevain jbevain deleted the remove-imetadatasymbolwriter branch January 29, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jbevain