-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang-tidy checks on CI #555
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 11 11
Lines 750 750
Branches 76 76
=======================================
Hits 747 747
Misses 3 3 ☔ View full report in Codecov by Sentry. |
…es into dev-jbcoe-run-clang-tidy
ed2b194
to
cea03de
Compare
cea03de
to
2b8dab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for applying the suggested changes.
Thanks for helping me sort the CMake issues |
Add a clang-tidy CI action.
Add a script to create a duplicate-free version of compile_commands.json so that we don't have multiple entries for any source file.
Make
.cc
source non-PRIVATE in CMake libraries so that it gets mentioned in compile_commands.json (There may be a nicer fix for this).Fixes #550