Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-tidy checks on CI #555

Merged
merged 13 commits into from
Feb 23, 2025
Merged

Add clang-tidy checks on CI #555

merged 13 commits into from
Feb 23, 2025

Conversation

jbcoe
Copy link
Owner

@jbcoe jbcoe commented Feb 14, 2025

Add a clang-tidy CI action.

Add a script to create a duplicate-free version of compile_commands.json so that we don't have multiple entries for any source file.

Make .cc source non-PRIVATE in CMake libraries so that it gets mentioned in compile_commands.json (There may be a nicer fix for this).

Fixes #550

@jbcoe jbcoe requested a review from Twon as a code owner February 14, 2025 12:44
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (840a406) to head (80592de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          11       11           
  Lines         750      750           
  Branches       76       76           
=======================================
  Hits          747      747           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbcoe jbcoe force-pushed the dev-jbcoe-run-clang-tidy branch 3 times, most recently from ed2b194 to cea03de Compare February 14, 2025 14:05
@jbcoe jbcoe force-pushed the dev-jbcoe-run-clang-tidy branch from cea03de to 2b8dab0 Compare February 14, 2025 14:10
@jbcoe jbcoe requested a review from Twon February 23, 2025 00:07
Copy link
Collaborator

@Twon Twon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for applying the suggested changes.

@jbcoe jbcoe merged commit be7823e into main Feb 23, 2025
35 checks passed
@jbcoe jbcoe deleted the dev-jbcoe-run-clang-tidy branch February 23, 2025 10:58
@jbcoe
Copy link
Owner Author

jbcoe commented Feb 23, 2025

Thanks for helping me sort the CMake issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate running of clang-tidy on CI
2 participants