Add alternative #[getset(...)] syntax #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreepySkeleton
commented
Jan 20, 2020
|
Closing and reopening to trigger CI run |
|
Huh? |
|
Thanks for this, @CreepySkeleton . :) It LGTM. Do you think it would be good to remove the 'old way' later? |
Hoverbear
approved these changes
Jan 21, 2020
|
More notably, do you think this should become the documented way in README.md? |
I don't think so, those are good shortcuts. The new way should be documented on docs.rs and in the readme. |
This was referenced Jan 29, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the alternative
#[getset(get, set, ...)]syntax as discussed in #5Closes #5