-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for src-files
not being used when specified in a config file
#2015
Conversation
@csalerno-asml thanks for starting this! This PR would need a regression test to be mergeable. Could you add one? |
Done @webknjaz :) |
15f6969
to
f5128b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to hold this back for now per #2006 (comment).
Any update @chrysle @atugushev @webknjaz ? |
@csalerno-asml #1966 is approved and will be merged once the CI gets unblocked (it's a repo-global blocker). |
Since that's now merged, could you rebase? |
447e5ae
to
6c7e65a
Compare
@chrysle done :) |
That's not a rebase, though. |
@webknjaz I rebased, but then there was a merge conflict (don't know why), so I just merged |
Well, this will cause a "foxtrot merge". |
51eafd4
to
a9e7f60
Compare
a9e7f60
to
e216ad5
Compare
@webknjaz re-rebased |
Thanks! |
hey @chrysle , do you know when this fix will be released? do you guys have a schedule, or a release strategy? |
Not really. There was some shared repo where releases could be requested, I think. |
From what I see, this is done manually? #1958 |
Let's make a release. I'll do it today. |
Released as part of pip-tools |
This PR fixes #2006
src-files
is found in the click context,ctx
, but however is not populating the variablesrc_files
, so that it is an empty tuple.For this reason, the tool will then start to select a requirement file, as shown in the linked issue.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.