Updated management commands for compatibility with Django 1.10 #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The management commands are now compatible with Django 1.8+. This was achieved by replacing the usage of option_list with add_arguments(). Additionally, unit tests have been added for the commands. Fixes #199
|
I was just thinking about writing a similar PR, thanks @clintonb! |
thallada
approved these changes
Jun 20, 2017
There was a problem hiding this comment.
It looks like this PR fixes the same issue as #236 does, but it has tests 🥇. I tested your branch out, and I'm now able to use the management commands in Django 1.11.
The only nitpicky thing I'll mention is that there's a few lines here over 80 chars long and that's inconsistent with the rest of the code base which seems to keep it under 80 chars.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The management commands are now compatible with Django 1.8+. This was achieved by replacing the usage of option_list with add_arguments(). Additionally, unit tests have been added for the commands.
Fixes #199