Replace setup.py by pyproject.toml
#707
Conversation
pyproject.toml
Outdated
| maintainers = [ | ||
| {name = "Claude Paroz", email = "claude@2xlibre.net"}, | ||
| ] |
There was a problem hiding this comment.
More maintainers can be added.
There was a problem hiding this comment.
I would be more than happy to see more names here. 🆘
There was a problem hiding this comment.
I know I'm not exactly active at the moment, but I'd be happy to have my name here 👍
pyproject.toml
Outdated
| maintainers = [ | ||
| {name = "Claude Paroz", email = "claude@2xlibre.net"}, | ||
| ] |
There was a problem hiding this comment.
I would be more than happy to see more names here. 🆘
| "F", # Pyflakes | ||
| "E", # pycodestyle (Error) | ||
| "W", # pycodestyle (Warning) | ||
| # "I", # isort (waiting for https://github.com/astral-sh/ruff/issues/2600) |
There was a problem hiding this comment.
Let me know if you'd like to use isort from Ruff even if it would require some formatting changes to imports
There was a problem hiding this comment.
If the changes are not too much invasive, I think it's fine.
There was a problem hiding this comment.
Yeah the thing is it was putting each imported object on a single line :/ Is it fine still? If the diff is too much we can add an entry to ignore the commit for blames
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #707 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 78 78
Lines 3384 3390 +6
Branches 384 384
=======================================
+ Hits 3311 3317 +6
Misses 42 42
Partials 31 31 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jeroen Dekkers <jeroen@dekkers.ch>
|
Thanks for finishing up, was lacking some time |
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: