Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease unnecessary database hits (#587) #588

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Decrease unnecessary database hits (#587) #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions silk/collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ def _record_meta_profiling(self):
query_time = sum(_time_taken(x['start_time'], x['end_time']) for _, x in self.silk_queries.items())
self.request.meta_num_queries = num_queries
self.request.meta_time_spent_queries = query_time
self.request.save()

def stop_python_profiler(self):
if getattr(self.local, 'pythonprofiler', None):
Expand All @@ -147,7 +146,6 @@ def finalise(self):
with open(self.request.prof_file.storage.path(file_name), 'w+b') as f:
ps.dump_stats(f.name)
self.request.prof_file = f.name
self.request.save()

sql_queries = []
for identifier, query in self.queries.items():
Expand Down
3 changes: 1 addition & 2 deletions silk/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ def _process_response(self, request, response):
collector.stop_python_profiler()
silk_request = collector.request
if silk_request:
silk_response = ResponseModelFactory(response).construct_response_model()
silk_response.save()
ResponseModelFactory(response).construct_response_model()
silk_request.end_time = timezone.now()
collector.finalise()
else:
Expand Down
3 changes: 2 additions & 1 deletion silk/model_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ def construct_response_model(self):
header, val = k, v
finally:
headers[header] = val
silky_response = models.Response.objects.create(
silky_response = models.Response(
request_id=self.request.id,
status_code=self.response.status_code,
encoded_headers=json.dumps(headers, ensure_ascii=SilkyConfig().SILKY_JSON_ENSURE_ASCII),
Expand All @@ -342,4 +342,5 @@ def construct_response_model(self):
except TypeError:
raw_body = base64.b64encode(content.encode('utf-8'))
silky_response.raw_body = raw_body.decode('ascii')
silky_response.save()
return silky_response