Remove deprecated import (gone in Django 1.9) #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 89.72% 89.86% +0.14%
==========================================
Files 25 25
Lines 1197 1194 -3
Branches 106 106
==========================================
- Hits 1074 1073 -1
+ Misses 91 89 -2
Partials 32 32
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 89.72% 89.86% +0.14%
==========================================
Files 25 25
Lines 1197 1194 -3
Branches 106 106
==========================================
- Hits 1074 1073 -1
+ Misses 91 89 -2
Partials 32 32
Continue to review full report at Codecov.
|
blueyed
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we're fine without
django.utils.importlib, which is removed in Django 1.9 and deprecated since at least Django 1.7.Relates to issue #190.