Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzband update for issue #164 #165

Merged
merged 53 commits into from
Dec 24, 2021
Merged

Jazzband update for issue #164 #165

merged 53 commits into from
Dec 24, 2021

Conversation

coordt
Copy link
Contributor

@coordt coordt commented Dec 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@e5785ed). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage          ?   64.97%           
=========================================
  Files             ?       24           
  Lines             ?     1122           
  Branches          ?      248           
=========================================
  Hits              ?      729           
  Misses            ?      299           
  Partials          ?       94           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5785ed...7300efe. Read the comment docs.

@PetrDlouhy
Copy link
Contributor

@coordt I have looked at this briefly and tried to run it in Django 4.0 without problem. I didn't find any major issues apart from the failing merge test.
Although I would add Django 3.2 and Django 4.0 to the testing matrix.

I also did found #168 bug in admin, but it is present in current version too.
Please also take look at my MR #149, which is making the Category.slug standard by adding unique constraint.

@coordt
Copy link
Contributor Author

coordt commented Dec 21, 2021 via email

@coordt coordt marked this pull request as ready for review December 22, 2021 18:17
@coordt coordt merged commit 0f09d7d into master Dec 24, 2021
@coordt coordt deleted the jazzband-update branch December 24, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants