100% test coverage #202
Merged
100% test coverage #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palfrey
commented
Dec 21, 2022
| @@ -130,8 +126,6 @@ def parse( | |||
| hostname = spliturl.netloc | |||
| if "@" in hostname: | |||
| hostname = hostname.rsplit("@", 1)[1] | |||
| if ":" in hostname: | |||
| hostname = hostname.split(":", 1)[0] | |||
There was a problem hiding this comment.
This came in as part of be4c7f2 and AFAIK this seems to work without it just fine. We certainly don't have a test case that breaks without it
palfrey
commented
Dec 21, 2022
| @@ -196,7 +191,4 @@ def parse( | |||
| if options: | |||
| parsed_config["OPTIONS"] = options | |||
|
|
|||
| if engine: | |||
| parsed_config["ENGINE"] = engine | |||
There was a problem hiding this comment.
engine is always Truthy as in the None case we parse it earlier on, so I've just set this directly in the earlier update call.
palfrey
commented
Dec 21, 2022
| else: | ||
| path, raw_query = path, spliturl.query | ||
| query = urlparse.parse_qs(raw_query) | ||
| query = urlparse.parse_qs(spliturl.query) |
There was a problem hiding this comment.
This came in in #59 but seems to work fine without it. Not sure if there was an issue in earlier (pre-3.x) Python parsing or something.
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
===========================================
+ Coverage 92.13% 100.00% +7.86%
===========================================
Files 1 1
Lines 89 82 -7
Branches 17 14 -3
===========================================
Hits 82 82
+ Misses 3 0 -3
+ Partials 4 0 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.