pci: don't pass chroot to pcidb with snapshots #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapshot implementation leverages chroot and transparently set it to the unpacked snapshot root. This is the intentional behaviour and ghw supports it. But the `pci` package passes throu the chroot settings to `pcidb` and the latter doesn't know or care about ghw snapshots - and rightly so! hence, we need to pass through the `chroot` setting only if explicitely set by client code - so if no snapshot settings are present. Signed-off-by: Francesco Romani <fromani@redhat.com>
jaypipes
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshot implementation leverages chroot and transparently set it to the unpacked snapshot root. This is the intentional behaviour and ghw supports it.
But the
pcipackage passes throu the chroot settings topcidband the latter doesn't know or care about ghw snapshots - and rightly so!Hence, we need to pass through the
chrootsetting only if explicitely set by client code - so if no snapshot settings are present.Signed-off-by: Francesco Romani fromani@redhat.com