Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect script/container behaviour that may result in broken installation/incompatible state #134

Closed
jiaz83 opened this issue Nov 13, 2024 · 9 comments
Assignees
Labels
Milestone

Comments

@jiaz83
Copy link

jiaz83 commented Nov 13, 2024

Whenever JDownloader is updating itself/Core, the main process is gone, while the helper installation process is applying the updates. The script currently doesn't properly wait for this process to finish, which then may result in incomplete installation of updates. In case of no or broken JDownloader.jar file, it is getting replaced by bundeled/old JDownloader.jar

Whenever the JDownloader.jar is replaced, it is important to also delete Core.jar file and the update directory.

Please feel free to get in contact with our support for further solution finding

1.) properly wait for updater process to finish
2.) update init script to also delete Core.jar file and update directory whenever JDownloader.jar file is replaced

@jiaz83
Copy link
Author

jiaz83 commented Nov 13, 2024

Also see #132

@pspzockerscene
Copy link

I may add that me and @jiaz83 are official JDownloader staff.

@kinslayer1982

This comment was marked as off-topic.

@jiaz83
Copy link
Author

jiaz83 commented Nov 19, 2024

@kinslayer1982 but still important to notify about this issue as others might clone/continue this project

@jaymoulin

This comment was marked as off-topic.

@jiaz83
Copy link
Author

jiaz83 commented Nov 19, 2024

@jaymoulin Thank you for your help and work here! Another docker project for JDownloader solved the waiting by just waiting for all java processes to finish instead of waiting for specific pid. Maybe that'll work here as well?
You need to remove Core.jar and the update folder in case you replace JDownloader.jar, both are important.

@pspzockerscene
Copy link

People like you are the main reason I don't want to code anymore

I feel this one! The only thing you can do is to ignore such comments and keep on going.

Back to topic:
The changes which jiaz means that were done in the other container project are these ones:
jlesage/docker-jdownloader-2@6a8a6b4

@kinslayer1982

This comment was marked as off-topic.

@jaymoulin
Copy link
Owner

Back to topic: The changes which jiaz means that were done in the other container project are these ones: jlesage/docker-jdownloader-2@6a8a6b4

This may be a good workaround if java is still a main process. This also may have an impact on performance. I (or anybody willing to PR) should be aware of that to contain this as possible

@jaymoulin jaymoulin self-assigned this Dec 20, 2024
@jaymoulin jaymoulin added the bug label Dec 20, 2024
@jaymoulin jaymoulin added this to the 2.2.0 milestone Dec 20, 2024
Repository owner locked as resolved and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants