Add float8_e4m3fnuz and float8_e5m2fnuz #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkinsp
approved these changes
Apr 11, 2023
jakevdp
reviewed
Apr 11, 2023
jakevdp
requested changes
Apr 11, 2023
|
Looks good - thanks. Would you mind squashing your changes into a single commit, just to help keep the history clean? Thank you! |
|
Sure. done 👍 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for two additional types
float8_e4m3fnuzandfloat8_e5m2fnuz. These match the types defined in LLVM/MLIR and proposed in StableHLO.