Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build for x86 platform on Windows #51

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

sotiredofyours
Copy link

@sotiredofyours sotiredofyours commented Jan 16, 2025

  • add new target for x86 platform on Windows
  • update upload-artifact to v4

@sotiredofyours sotiredofyours mentioned this pull request Jan 16, 2025
@Ousret Ousret self-requested a review January 16, 2025 13:49
@Ousret Ousret linked an issue Jan 16, 2025 that may be closed by this pull request
@sotiredofyours
Copy link
Author

Oh, it seems that didn't work...
I tried building for one version here, and it worked well. I'll try testing it on the whole pipeline. I'm not sure where the CI is getting the x64 Python interpreter from.

@Ousret
Copy link
Member

Ousret commented Jan 16, 2025

No, the contrary, it worked. https://github.com/jawah/qh3/actions/runs/12808702473/job/35717246996?pr=51

We must exclude x86 with PyPy AND 3.13t.

Please install the whl win32 fmt and report back.

Run:

pip install qh3-1.3.1-cp37-abi3-win32.whl
python -c "import platform; import qh3; print(platform.machine(), qh3.__version__)"

And present to us the results here.

Regards,

@Ousret
Copy link
Member

Ousret commented Jan 16, 2025

The built wheel is
qh3-1.3.1-cp37-abi3-win32.zip

unzip it prior to install

@sotiredofyours
Copy link
Author

sotiredofyours commented Jan 16, 2025

Now I see.
I have tested this .whl file, and it works as expected. The result is as follows:
x86 1.3.1
I excluded the build for other versions (pypy, 3.13t) and everything should work properly

@sotiredofyours
Copy link
Author

sotiredofyours commented Jan 17, 2025

Seems like artifacts from v3 and v4 are conflicted.
I belive that whole new CI run (w/o any artifacts) run should fix this errors

Copy link
Member

@Ousret Ousret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@Ousret Ousret merged commit 8884d2f into jawah:main Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Win32 support
2 participants