Skip to content

Commit

Permalink
minor symfony#16870 [Console] Update questionhelper.rst (issamkhadiri…
Browse files Browse the repository at this point in the history
…1989)

This PR was submitted for the 6.0 branch but it was merged into the 4.4 branch instead.

Discussion
----------

[Console] Update questionhelper.rst

hello,

when running the example as it is, a deprecation message is shown (i'm on PHP 8.1.6). the deprecation message says that ``trim(): Passing null to parameter #1 ($string) of type string is deprecated``.
what if we add a normalizer that returns an empty string when the entered value is `null` otherwise returns the user's intial input.  with this suggestion, the example works great

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Commits
-------

bf9e245 Update questionhelper.rst
  • Loading branch information
javiereguiluz committed Jun 28, 2022
2 parents f065b76 + bf9e245 commit b24c8a4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions components/console/helpers/questionhelper.rst
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,9 @@ You can also use a validator with a hidden question::
$helper = $this->getHelper('question');

$question = new Question('Please enter your password');
$question->setNormalizer(function ($value) {
return null === $value ? '' : $value;
});
$question->setValidator(function ($value) {
if (trim($value) == '') {
throw new \Exception('The password cannot be empty');
Expand Down

0 comments on commit b24c8a4

Please sign in to comment.